flowpack/flowpack.listable

Neos package that helps you to render lists of things

flowpack.listable's Issues

Add tests to public API

We should test TS objects. E.g. see how TS tests are implemented in TypoScript package itself e.g. here https://github.com/neos/neos-development-collection/blob/master/TYPO3.TypoScript/Tests/Functional/TypoScriptObjects/TagTest.php#L23.

Replace deprecated Fusion prototypes

According to the docs:

• Neos.Fusion:Array being used here and here is deprecated and should be replaced with Neos.Fusion:Join
• Neos.Fusion:RawArray being used here is deprecated and should be replaced with Neos.Fusion:DataStructure.
• Neos.Fusion:Collection being used here and here is deprecated and should be replaced with Neos.Fusion:Loop

Default classes for bootstrap setup in demo site?

May be it makes sense to detect or configure a framework (like bootstrap in the demo site), and have the list objects automatically render withe the corresponding css IDs and classes.

Think of good names for API objects

Rename Listable to List and List to something else, like TitledList.
Perhaps we should gather more feedback on this topic.

Last page is not shown everytime

If there is a pagination where "..." is displayed before the last page number, the last page number is not displayed when you are on the page where the "..." disappears.

I recognized this behavior in multiple projects and all had the same effect.

Routing seems not to work

According to the Routes.yaml which should be auto-included, I should be able to use URLs like /de/news~p2.html, correct?
This seems to be broken.

Version consistency

The current version tag 2.0.2 should be 3.0 as it's a breaking change and makes every package that depends on Listable incompatible.

Description Link in repo not working

The description links goes to a 404 site on packagist

Consolidating to one node type?

I find the Sfi.Listable:Listable name a little non-descriptive and it may not be neccessary.
What about only providing a Sfi.Listable:List?
If no wrapping elements are defined, the default behavior could be that of the current Listable node.

skip or offset

I could not find offsets (skipping to list the first n items (as they may be rendered in full lengh just above the list).

[feature request] Fusion property for "empty list text"

Hi guys,

a property for an alternative text which is shown if the list is empty.

For example listable projects:

prototype(XY.xy:ProjectList) < prototype(Flowpack.Listable:List) {
    alternativeText = 'No projects'
}

Mention in documentation that collections cannot be passed with props to PaginatedCollection

Flowpack.Listable:PaginatedCollection has a collection key that must be set by the user.

The documentation shows an example:

prototype(My.Custom:Object) < prototype(Flowpack.Listable:PaginatedCollection) {
  collection = ${Search.query(site).nodeType('Something.Custom:Here').sortDesc('date')}
  ...
}

When passing the same search query as prop, it does not work:

prototype(My.Custom:Object) < prototype(Neos.Fusion:Component) {
  collection = ${Search.query(site).nodeType('Something.Custom:Here').sortDesc('date')}
  
  renderer = Flowpack.Listable:PaginatedCollection {
    collection=${props.collection}
  }
}

It was hard to find out and took me several hours of debugging to realize that this is simply not possible because of the caching configuration of PaginatedCollection, because the data passed is not saved with the cache entry (see @cache.context).

I'm not sure where exactly, but might it be worth mentioning this in the README or in the code of the fusion component itself?

date dependant listings

Allow to limit and paginate based on date property? For example, show only past/next month or year, and paginate to past/next year.

Method `count` is not callable in untrusted context (`totalCount`)

I get an error in combination with Flowpack Simple search at line:

Flowpack.Listable/Resources/Private/Fusion/PaginatedCollection.fusion

Line 31 in 0dfe9e2

totalCount = ${Type.getType(props.collection) == 'array' ? q(props.collection).count() : props.collection.count()}

props.collection has changed in Flowpack.SimpleSearch with this pr:
https://github.com/Flowpack/Flowpack.SimpleSearch.ContentRepositoryAdaptor/pull/39/files#diff-ffc206e78cb0c19096185c41a6daf40384dee16565b7a919e5438c6ce1d2cb7fR223

and is no longer a simple array but and \ArrayIterator or better a \Traversable

the fusion in totalCount should be changed to account for \Traversables

a current workaround is to call Array.values on props.collection before passing it to Flowpack.Listable:PaginatedCollection