fluendo/cerbero

cerbero's Issues

Adding patches to git based recipe

When a patch is added to a git based recipe which was already build (or at least build directory was created from repo), the new patches won't be applied. It's because of check inside extract method in GitCache class:

  def extract(self):
     if os.path.exists(self.build_dir):
         # fix read-only permissions
         if self.config.platform == Platform.WINDOWS:
             shell.call('chmod -R +w .git/', self.build_dir, fail=False)
         try:
             commit_hash = git.get_hash(self.repo_dir, self.commit)
             checkout_hash = git.get_hash(self.build_dir, 'HEAD')
             if commit_hash == checkout_hash:
                 return False
         except Exception:
             pass
         shutil.rmtree(self.build_dir)
     if not os.path.exists(self.build_dir):
         os.mkdir(self.build_dir)
     if self.supports_non_src_build:
         return

     # checkout the current version
     git.local_checkout(self.build_dir, self.repo_dir, self.commit)
     # apply the patches only after checkout to avoid failure with patches already applied.
     self.apply_patches()
     return True`

Build directory has to be removed manually in order to apply new patches.
One of the solutions that might work: always do a 'git reset --hard ...' and always apply patches.