fmi/java-course

Материали към курса "Съвременни Java технологии"

java-course's Issues

EchoServer.java has unreachable if statement.

According to the documentation about thejava.nio.channels.Selector:

This method performs a blocking selection operation. It returns only after at least one channel is selected, this selector's wakeup method is invoked, or the current thread is interrupted, whichever comes first.

This means that the if (readyChannels == 0) { is redundant and unreachable in https://github.com/fmi/java-course/blob/master/11-network/snippets/echoclientserver/nio/EchoServer.java#L31

testIfPaymentFailsIfNullPaymentIsPassed passes when it shouldn't

java-course/02-oop-in-java-i/lab/SampleVirtualWalletTest.java

Line 80 in f61ebad

assertFalse(wallet.executePayment(standardCard, null));

Този тест ми минава, без да имам check за null PaymentInfo. Причината е, че проверявам дали картата е регистрирана първо и понеже не е -> return false.

Fix:
assertTrue(wallet.registerCard(standardCard)); assertFalse(wallet.executePayment(standardCard, null));

Lecture 1 question

Сигурни ли сте, че https://github.com/fmi/java-course/blame/master/01-intro-to-java/lecture/PITCHME.md#L651 работи?

Според https://docs.oracle.com/en/java/javase/13/docs/api/java.base/java/util/Arrays.html Arrays.sort(char[] a) връща void. В лекцията се извиква .toString() директно на return value-то, но няма такова.

Когато го изпробвах, още IDEто ми се кара с cannot resolve method.

ПС: Не знам дали тук трябваше да вдигам issue-та, ако не е правилното място се извинявам :/

Race condition in 09-network's tests

Several runs on the given tests in 09-network reveal that (randomly) some of them sometimes fail and sometimes don't.
I suspect the problem comes from the fact that the server is on a different thread, thus a test may try to connect to the server before it has started.

The solution would be making each test wait for the server untill it has started. But I fail to find a painless and elegant way to do this in the current setup. How could this problem be fixed?