fnoks/h5p-mc

h5p-mc's Issues

Status of MiniCourse

Hi @fnoks !

Some people wonder if the MiniCourse content type is still under development and I just take the liberty to ask as a proxy.

Would you mind posting a brief status update here?

• What'd be left to do?
• Will you continue working on it if you find some free time? Or has it maybe been abandoned? Interactive Book has quite some similar functionality although not all the options of MiniCourse.
• Should someone in the community take over?

Replace detection of scorables?

h5p-mc/src/scripts/CourseUnit.js

Line 72 in 8a27ec8

if (scorables.indexOf(this.getMachineName()) !== -1) {

Could this be replaced by

if (typeof this.getInstance().getMaxScore === 'function' && this.getInstance().getMaxScore() > 0) {

??? If a maximum score larger than 0 can be achieved, an instance should be scorable, right? Or is there a reason for handling this using a hard coded list? There's no comment indicating why it might be used.

Having hard coded lists such as

h5p-mc/src/scripts/CourseUnit.js

Lines 6 to 21 in 8a27ec8

	const scorables = [
	"H5P.ImageHotspotQuestion",
	"H5P.Blanks",
	"H5P.SingleChoiceSet",
	"H5P.MultiChoice",
	"H5P.TrueFalse",
	"H5P.DragQuestion",
	"H5P.Summary",
	"H5P.DragText",
	"H5P.MarkTheWords",
	"H5P.MemoryGame",
	"H5P.QuestionSet",
	"H5P.InteractiveVideo",
	"H5P.CoursePresentation",
	"H5P.Flashcards"
	];

causes trouble quite frequently.

Given the currently supported content types, there are only Fill in the Blanks and Column that would not get caught correctly:

• Fill in the Blanks reports a maxScore of 0 before it is attached to the DOM, but there's already a fix pending for this problem.
• Column is not inside that hardcoded list, although it reports the maxScore reliably (except for when it contains "Fill in the Blanks"), so I am not sure why it's excluded from the "scorables"