Giter Site home page Giter Site logo

Comments (3)

esalman-sfdc avatar esalman-sfdc commented on August 16, 2024

I am wondering how can this be achieved without making the tests flappy/brittle. For example, for selenium/webdriver as well it has become a fairly standard best-practice to wait for something vs sleeping as a result of test owners getting burnt by flaky results :)

As you pointed out, if all components have locker enabled (v.40+) its easier to do (by letting the library add some marker). Is there anything else that the component under test do you could wait on (directly or via a test-wrapper component)?

Basically I am worried that providing a utility like sleep (well versed users like yourself may not be impacted as much) may result in adoption of an anti-pattern (one that results in false positives when it comes to failures).

What do you think?

from lightningtestingservice.

keirbowden avatar keirbowden commented on August 16, 2024

I take your point about the fact that sleeping is brittle, but I'm also loathe to set attributes solely for the purpose of indicating to tests that they can proceed. Interesting that you bring up Selenium as that was the same direction I was coming from. I'll have a bit more of a think about it over the next few days.

from lightningtestingservice.

keirbowden avatar keirbowden commented on August 16, 2024

I'll cave on this one - I can't come up with a good rebuttal to your reasons :)

from lightningtestingservice.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.