Giter Site home page Giter Site logo

Comments (13)

digitalcraftsman avatar digitalcraftsman commented on July 23, 2024 1

Or if you prefer simply perform a search and replace so that:
Gatsby --becomes--> Hugo in the content files of the Novela exampleSite

That might be more confusing than beneficial. Some posts explain concepts that are specific to Gatsby and even contain JS / React code snippets, e.g. in
https://hugo-novela-forestry.netlify.com/post/2019-04-31-understanding-the-gatsby-lifecycle/

from hugo-theme-novela.

regisphilibert avatar regisphilibert commented on July 23, 2024 1

Let's take a deep breath here.

This theme is good and should remain in the directory, that being said I agree content should be generic and don't promote any brand, it being open source or not. And that all themes should follow the guidelines, that goes without saying.

I'll see if we can help @DirtyF and make the content more generic before the end of next week.

Thanks.

from hugo-theme-novela.

DirtyF avatar DirtyF commented on July 23, 2024

@bep agreed, it feels weird, any existing content I could use? I prefer not to replace with fake text.

from hugo-theme-novela.

onedrawingperday avatar onedrawingperday commented on July 23, 2024

any existing content I could use?

Hello @DirtyF please have a look at the content files of the hugoBasicExample.

Or if you prefer simply perform a search and replace so that:
Gatsby --becomes--> Hugo in the content files of the Novela exampleSite

Once you look into the above please let me know, so that I can update the theme demo on the Hugo website.

Thanks.

from hugo-theme-novela.

onedrawingperday avatar onedrawingperday commented on July 23, 2024

Hello again @DirtyF

Can you please look into this issue and let me know?

As mentioned above you can use content files from the hugoBasicExample repo.

from hugo-theme-novela.

onedrawingperday avatar onedrawingperday commented on July 23, 2024

Hello again @DirtyF

I understand that this issue may not be a priority for you.

However almost a month has passed since the original request was made about removing the Gatsby references from the theme's content files.

As of today the Novela theme's demo and homepage links have been disabled on the Hugo Themes website until this issue is resolved.

So whenever you find the time to fix the content files, please notify me, so that the demo and the homepage links are restored on the Hugo Themes website.

Thank you.

from hugo-theme-novela.

DirtyF avatar DirtyF commented on July 23, 2024

Some generic content would be better.

So now it is mandatory… that escalated quickly.

from hugo-theme-novela.

onedrawingperday avatar onedrawingperday commented on July 23, 2024

I fail to see the escalation. We made a polite request and we didn't quite get a meaningful reply or a time frame for resolution in 25 days.

Please keep communication to a minimum. We are busy people.

If you do not plan to fix the demo content then simply close this issue and I will then completely remove the theme from the Hugo Themes website.

Only if you issue a fix as requested above do contact me.

Thanks.

from hugo-theme-novela.

bep avatar bep commented on July 23, 2024

@DirtyF I suggest Forestryio comes up with some generic content you can use in situations like these. And do remember that 1) we run Hugo and its sites on very limited resources (as in: man-hours) so we need to make it as effective as possible 2) I'm pretty sure it is in our guidelines that the content should be neutral/non-promotional. If not, I'll see to it. I suspect this would have been easier to handle if we had handled this before we merged it into the theme repo in the first place. It should be obvious to most people that we cannot be a poster stand for competing products.

from hugo-theme-novela.

onedrawingperday avatar onedrawingperday commented on July 23, 2024

I'm pretty sure it is in our guidelines that the content should be neutral/non-promotional. If not, I'll see to it

@bep It used to be in the guidelines. However after we made theme demos inherit their content from the hugoBasicExample, I removed that reference months ago.

However after this incident, I have re-added the reference and expanded on it over here:
https://github.com/gohugoio/hugoThemes#example-site

So yes it is mandatory. Typically we do not see such problems with theme submissions.
When this theme was submitted I was away. My fellow maintainer had plenty of themes to review. It's only human that the problem with this theme's content files was not spotted on time.

However that does not mean that we will keep this theme's promotional content in its demo forever on the website. 25 days was already too long.

from hugo-theme-novela.

DirtyF avatar DirtyF commented on July 23, 2024

I'll see what I can do, but it's definitely not up in my priorities at the moment. Feel free to remove the theme from your directory, if it makes you less threatened by Gatsby 🤷‍♂

from hugo-theme-novela.

onedrawingperday avatar onedrawingperday commented on July 23, 2024

Thank you @regisphilibert


@DirtyF

For the record the Hugo team does not feel threatened by any other product.

There is a simple rule that needs to be followed:
We do not accept promotions of any kind on the Hugo Themes website.

from hugo-theme-novela.

onedrawingperday avatar onedrawingperday commented on July 23, 2024

@DirtyF

Following the merging of #9 that addressed this issue.

The Novela theme demo was restored on the Hugo Themes website with gohugoio/hugoThemes@5391386

However note that the Homepage button was not restored because the external demo still features the old content.

If you want the link to the external demo re-enabled, you will also need to update the external demo's content and notify me.

from hugo-theme-novela.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.