formcarry/formcarry-react

React library of https://formcarry.com

formcarry-react's Issues

Issues with typescript as peer dependency

Hi

We're getting issues with this package due to the outdated typescript dependency. I would think typescript should only be a dev dependency anyways...

Invalid Hook Call

I've just installed @formcarry/[email protected]. When I run my app I see the following error from React.

Error: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://fb.me/react-invalid-hook-call for tips about how to debug and fix this problem.

I think this is being caused by problem 3 in the list, i.e. two copies of react. Reading the linked documentation it suggests running npm ls react to see which versions of react are installed in the deps tree. Running that shows me this.

├─┬ @formcarry/[email protected]
│ ├─┬ [email protected]
│ │ └── [email protected] deduped
│ └── [email protected]
├─┬ @netlify/[email protected]
│ └─┬ @sls-next/[email protected]
│   └─┬ @aws-sdk/[email protected]
│     └─┬ @aws-sdk/[email protected]
│       └─┬ [email protected]
│         └─┬ [email protected]
│           └── [email protected]
├─┬ [email protected]
│ ├─┬ @next/[email protected]
│ │ └── [email protected] deduped
│ ├── [email protected] deduped
│ ├─┬ [email protected]
│ │ └── [email protected] deduped
│ └─┬ [email protected]
│   └── [email protected] deduped
├─┬ [email protected]
│ └── [email protected] deduped
└── [email protected]

Which does show that there are two versions of react installed at different versions.

I think @formcarry/react should have a peer dependency on react instead of a hard dependency to avoid this duplication issue. This SO answer supports this as the correct fix too.

I'll open a PR now to change it over as it should be straight forward.