foxbms/mcu-primary

foxBMS Primary MCU0 Software

The foxBMS Project

foxBMS is a free, open and flexible development environment to design battery management systems. It is the first modular open source BMS development platform.

foxBMS 2

• Sources are available at https://www.github.com/foxBMS/foxbms-2
• latest version foxBMS 2 documentation
• Previous versions of the foxBMS 2 documentation
• Links to specific version are permalinks (e.g., foxBMS 2 version 1.0.0)

foxBMS 1

⚠️ Refer to foxBMS 2 as foxBMS 1 is no longer supported or updated ⚠️

Contact

For more information or if you want to give use some feedback, please contact us.

The Fraunhofer IISB foxBMS Team

foxbms.org

mcu-primary's Issues

array boundaries of DATA_BLOCK_CELLTEMPERATURE_s.temperature[] are violated

Affected files

cansignal_cfg.c

Description

If a system is not equipped with all available temperature sensors this violation will cause wrong temperatures to be displayed via CAN.

For Example

In a System equipped with one temperature sensor and one slave module the array in the database block DATA_BLOCK_CELLTEMPERATURE_s has one element.
In the cans_gettemp(uint32_t sigIdx, void *value) the datablock is read. If the first CAN Message is send this function will be called and the temperatures for the first three sensors are read: tmpVal = temp_tab.temperature[(modIdx * BS_NR_OF_TEMP_SENSORS_PER_MODULE) + cellIdx];
since the array has only one element the values read for the second and third temperature value are not temperatures, but the next entries in the struct DATA_BLOCK_CELLTEMPERATURE_s
this leads to a cell temperature for module 0 cell two showing the previous_timestamp

Possible Solution

I suggest adding a line of code to check the array boundaries. To prevent confusion fill the unused temperatures with a default value.

The same problem exists with the valid flags for the temperatures since the array size will change with the number of modules.