foxhound87/mobx-react-matchmedia

A React HOC with mediaqueries for responsive layout

mobx-react-matchmedia's Issues

Fragment instead of div

hello,
can you support choosing the type of the wrapper div, to be something custom? like Fragment or span ?
thank you

bug: nested components doesn't work

Hi,

I have a parent component wrapped with MatchMediaProvider, and it has a nested child component also wrapped with MatchMediaProvider.

The inner nested component doesn't work. moreover, it uses the same "breakpoints" of the parent, regardless of what I pass to it in the breakpoints property. even passing empty object, makes it think i used the same breakpoints value of the parent.

React PropTypes warning

Thannks for this awesome library! I was trying to look up examples of using matchMedia with mobx and found this. Works as expected, however I'm getting a couple React PropType warnings:

Warning: You are manually calling a React.PropTypes validation function for the `children` prop on `MatchMediaProvider`. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

Same thing with breakpoints prop on MatchMediaProvider. I followed the example usage, so I'm not sure if it's just something on my side or not. Looking at your src, I don't see anything that would cause the warning so I'm at a loss.

SSR doesnt seem to be working

Hello,

This library appears to not support SSR. Is this the case?
Using it with NextJs does not work as expected.

And looking over the source I can see that the technique to determine the window width will not work with SSR.

Any plans to add this in the future?

Regards

prop-types package warning from latest React.

warning.js:36 Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

Looks like the prop-types package needs to be added for latest React / React 16.

Can it be a single store?

So that store can be injected into any component and be used from there?

Transaction

Right now lib is creating lot of noise in if it used with mobx-react-devtools and with many breakpoints. Good idea would be to update breakpoints using transaction probably - it will invoke one "event" change after all updates.