rails 6 upgrade

[phoet]

rails 6 upgrade

[fphilipe]

Thanks. I've bumped the ruby version here, which causes Travis CI to run the specs for rails master (they're passing).

With this you should be able to point to this repo in your project without having to fork it. Once rails 6 is out, I'll change the gemspec to require rails < 7 so it can pick up the final rails 6 version.

[phoet]

@fphilipe unfortunately this is not correct!

you still have a version requirement of rails actionmailer < 6 in the gemspec which makes it necessary to fork it!

see this change of the PR https://github.com/penseo/premailer-rails/pull/1/files#diff-122c0cc5159b5325eba36306429d40b2R25

[fphilipe]

@phoet I think you're mistaken. This is a feature of semantic versioning (see spec item 11):

When major, minor, and patch are equal, a pre-release version has lower precedence than a normal version. Example: 1.0.0-alpha < 1.0.0.

That is the reason why bundler was able to resolve the requirements in this build. If that were not the case, it would have failed to install the gems.

[phoet]

ah, TIL!

🤔 bundler must have choked on this dependency for another reason then...

thanks for the linked info.

[fphilipe]

On Travis it choked because I was using ruby 2.4.1 and rails 6 requires ruby version >= 2.5.0.