Comments (7)
This will be fixed by #13
from premailer-rails.
I recomment this issue since it was ignored in the referenced #13 issue. Am I missing something? I'd like a way to ignore some CSS rules.
from premailer-rails.
I think the way I understood this is that people want the linked CSS file and style tags to not be removed from the HTML. This can be done by setting the preserve_styles
option to true.
from premailer-rails.
Apart from that, my feature request is this:
Add a tag, a special comment, or whatever to ignore a portion of CSS, by just leaving it there and not inlining the rules.
This is indispensable for using media queries and add device-based optimization of the mail.
The ideas explained here are useful: peterbe/premailer#16
(note that this is not https://github.com/alexdunae/premailer)
from premailer-rails.
Since premailer-rails3 is merely a wrapper around premailer, passing custom CSS to the underlying premailer object, this would need a change in premailer. The method that does the loading is this: https://github.com/alexdunae/premailer/blob/master/lib/premailer/premailer.rb#L231
Another option would be to completely disable this method by redefining it as an empty method. premailer-rails3 already analyzes the html for linked CSS files and passes the contents as string to the underlying premailer object, so this method has no effect. Then we could ignore linked stylesheets that are marked accordingly.
from premailer-rails.
I found this fork. It's not exactly what I proposed, but can practically lead to it: bdotdub/premailer@f446cd7
P.S. The Readme of premailer-rails3 is wrong, since PremailerRails.config should be PremailerRails3.config
from premailer-rails.
There's even a pull request: https://github.com/alexdunae/premailer/pull/104
I even tweeted him to accept it https://twitter.com/#!/Facens/status/170658749013442561
Meanwhile, I'm using the fork :)
from premailer-rails.
Related Issues (20)
- Encoding changes when premailer is ran HOT 11
- Unable to use the premailer-rails with rails version 3.2.22 HOT 1
- Inlined stylesheet is incorrectly encoded HOT 2
- can't modify frozen String HOT 4
- RTL support HOT 1
- bump premailer version HOT 2
- skip_premailer: false does not work HOT 1
- Allow NetworkLoader to be configured with support for proxied requests HOT 2
- Webpack and Sidekiq not sending emails on non-test environments HOT 1
- Stylesheets not working with email layout on haml HOT 1
- Looking for new maintainers? HOT 12
- Support CSSParser option rule_set_exceptions HOT 2
- Add Propshaft support
- Warning: already initialized constant Net::ProtocRetryError HOT 1
- "no implicit conversion of URI::HTTPS into String" exception after upgrading to 1.12.0 HOT 4
- Instrumentation support HOT 1
- Ruby 3.3.0 error HOT 3
- Generated `html_part` breaking tests after upgrade to 1.11.0
- Allow configuration of Mailer base class HOT 1
- Improve header `:skip_premailer` checking
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from premailer-rails.