Giter Site home page Giter Site logo

Comments (7)

fphilipe avatar fphilipe commented on May 27, 2024

This will be fixed by #13

from premailer-rails.

Facens avatar Facens commented on May 27, 2024

I recomment this issue since it was ignored in the referenced #13 issue. Am I missing something? I'd like a way to ignore some CSS rules.

from premailer-rails.

fphilipe avatar fphilipe commented on May 27, 2024

I think the way I understood this is that people want the linked CSS file and style tags to not be removed from the HTML. This can be done by setting the preserve_styles option to true.

from premailer-rails.

Facens avatar Facens commented on May 27, 2024

Apart from that, my feature request is this:
Add a tag, a special comment, or whatever to ignore a portion of CSS, by just leaving it there and not inlining the rules.
This is indispensable for using media queries and add device-based optimization of the mail.

The ideas explained here are useful: peterbe/premailer#16
(note that this is not https://github.com/alexdunae/premailer)

from premailer-rails.

fphilipe avatar fphilipe commented on May 27, 2024

Since premailer-rails3 is merely a wrapper around premailer, passing custom CSS to the underlying premailer object, this would need a change in premailer. The method that does the loading is this: https://github.com/alexdunae/premailer/blob/master/lib/premailer/premailer.rb#L231

Another option would be to completely disable this method by redefining it as an empty method. premailer-rails3 already analyzes the html for linked CSS files and passes the contents as string to the underlying premailer object, so this method has no effect. Then we could ignore linked stylesheets that are marked accordingly.

from premailer-rails.

Facens avatar Facens commented on May 27, 2024

I found this fork. It's not exactly what I proposed, but can practically lead to it: bdotdub/premailer@f446cd7

P.S. The Readme of premailer-rails3 is wrong, since PremailerRails.config should be PremailerRails3.config

from premailer-rails.

Facens avatar Facens commented on May 27, 2024

There's even a pull request: https://github.com/alexdunae/premailer/pull/104
I even tweeted him to accept it https://twitter.com/#!/Facens/status/170658749013442561
Meanwhile, I'm using the fork :)

from premailer-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.