query for if asset pipeline is enabled is ineffective in Rails 4

[fphilipe]

query for if asset pipeline is enabled is ineffective in Rails 4

[fphilipe]

I'm planning on moving the asset loading stuff into a separate gem. Just haven't found the time for it... I might need to use premailer-rails at work again, so that will give me a great opportunity to improve the gem.

[johnmcdowall]

This change in check fixes this annoying bug in Rails 4.

[jjb]

Hi @johnmcdowall -- not sure I understand. Did you mean to reference a checkin in your comment?

[fphilipe]

@jjb checkin == commit?
@johnmcdowall Could you elaborate, please? 😊

[johnmcdowall]

I was just saying that if you change the Asset Pipeline check as @jjb originally said at the top, it fixes the bug on Rails 4.

[jjb]

@johnmcdowall gotcha

the problem is i didn't test with the other two asset pipeline scenarios (precompile locally and commit, compile live on the server), i only tested it with my own (precompile while deploying)

[jjb]

@fphilipe 1.5.1 works for my rails 4 app, so i believe this issue can be closed.

thanks for all your recent attention to this project!

[jjb]

hmm actually... it looks like you are still querying for a nonexistent config... so i guess the problem was solved in another part of the code, where you check for things in a different order... i'll tentatively reopen this for future reference...

[fphilipe]

I released v1.6.0. I think this should be fixed now.

[jjb]

wow, great to see attention to this great project! thanks @fphilipe!

[fphilipe]

@jjb There's more in the pipeline. I'm planning on replacing the rudimentary cache with ActiveSupport::Cache. This will allow you to simply set Rails.cache as the cache.

[jjb]

great!

On Wed, Nov 20, 2013 at 12:40 PM, Philipe Fatio [email protected]:

@jjb https://github.com/jjb There's more in the pipeline. I'm planning
on replacing the rudimentary cache with ActiveSupport::Cache. This will
allows you to simply set Rails.cache as the cache.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/84#issuecomment-28910945
.