fredricrylander/angular-webstorage

Web Storage Service Module for AngularJS

angular-webstorage's Issues

version 0.11.0 not in bower

I am unable to get version 0.11.0 from bower

Error on has(key) check if not set

When checking for the existence of a key before setting a value, I get the an error, e.g.

console.log(webStorage.has('user'));

generates...

Uncaught TypeError: undefined is not a function 

Am I missing something?

Session storage should not fallback to cookies

Session storage is, by design intended for potentially private data.
For this reason, it cannot be shared between tabs, or persist. And it is for this reason I think you should consider removing the cookie fallback for sessions storage. (or make it configurable)

---

Great work elsewhere by the way, great plugin!

Clearing sessionStorage contains slight bug

https://github.com/fredricrylander/angular-webstorage/blob/master/angular-webstorage.js#L463 should check keys in sessionStorage, not localStorage

Would be great to have add(key,value) appending to existing values instead of rewriting it and get(key) should return an array of values for key?

Add to Bower registry?

This would be useful to have on the Bower registry - perhaps you can add a Bower json manifest then bower register angular-webstorage https://github.com/fredricrylander/angular-webstorage.git?

throw access denied exception on IE10/Windows8 when IE10 under Protected Mode.

Will throw access denied exception when IE10 under Protected Mode on the code
if (!window.localStorage) {

Allow setting empty object

Hi,
you should allow setting empty object as

webStorage.add('ordersList', {}, true);

Just update your doc (the code already works)

New release version

It would be useful to create a new version (tag) for the last merge, to reference from package.json.

If I try to reference your library from my package.json it doesn't find the package.json because it's not in version 0.14.0.

change bower dependency to the latest angularjs

The bower.json is depending on the angular 1.0 or 1.1 which is much old, can you please change it to the newer version like 1.2.7? It's causing issue that bower always ask for conflict resolution when running bower install...

"dependencies": {
"angular": ">=1"
}

Is LocalStorage always supported?

Just wondering - is localStorage always supported, since a fallback document.cookie implementation is provided if !window.localStorage:

https://github.com/fredricrylander/angular-webstorage/blob/master/angular-webstorage.js#L534-L576

If this actually is the case, I'd suggest replacing the 'memory' storage type with a new 'cookie' type, if document.cookie is always accessible (I'm not sure whether it is or not).

Naming of `add()`

If there a reason you opted for add() in the API? I personally think it should be set() and get().
add() almost implies its just for adding , and not updating as well.

How to specify the order in my app config?

I am trying to set the order of the storage.
Is there a way to do it as part of the angular app.config?

Example

var App = angular.module('App', ['webStorageModule']);
App.config(function ($routeProvider, webStorage, $httpProvider) {
  webStorage.order('local', 'session', 'memory');
});

Not actually using the errorName constant

https://github.com/fredricrylander/angular-webstorage/blob/master/angular-webstorage.js#L120

Trailing commas of death

The module got 3 trailing commas of death that makes IE choke, on lines 161, 175, 189 and 190.