freepbx/cidlookup

Module of FreePBX (CallerID Lookup) :: Allows CallerID Lookup of incoming calls against different sources (OpenCNAM, MySQL, HTTP, ENUM, Phonebook Module)

cidlookup's Issues

[improvement]: Add custom Cache-Time

FreePBX Version

FreePBX 16

Improvement Description

Actual the cache option is just on/off.
But there is no info or adjustment for the cache-time.
It would be great to customize this with a new form field.

[improvement]: Add the target as Query-Parameter

FreePBX Version

FreePBX 16

Improvement Description

There is no query-paramter to optional send infos about the called target.
I am new to asterisk, so i am not sure if target is the correct word.

[improvement]: timeout and error-ressistant

FreePBX Version

FreePBX 16

Improvement Description

If there is an error in the config or the response took longer than a new configurable field timeout (in seconds), it would be great to just skip the caller id lookup and just process the phone call.

Maybe for HTTP/S-Requests
curl_setopt($curl, CURLOPT_TIMEOUT, 2);

https://www.php.net/manual/en/function.curl-setopt.php

[bug]: Module: "CallerID Lookup" is giving out the string “Unknown” instead of the Phonenumber

FreePBX Version

FreePBX 16

Issue Description

Module Affected:

CallerID Lookup since 16.0.13
https://github.com/FreePBX/cidlookup

Expectation:

In case the Phonenumber of an Inbound-Call is not found in the CallerID Database, the actual Phonenumber should be provided to the Extension. (Phonenumber = CallerID)

What it actually did

Since Module Version 16.0.13 the CallerID Lookup (Type MySql) is giving out the string “Unknown” instead of the Phonenumber.

The Bug was corrected in 16.0.12.
The Bug was reintroduced in 16.0.13.
The Bug is still there in 16.0.15.

Bugfix:

diff --git a/cidlookup_mysql.agi b/cidlookup_mysql.agi
index bd0ad0c..7b9526d 100644
--- a/cidlookup_mysql.agi
+++ b/cidlookup_mysql.agi
@@ -51,8 +51,6 @@
     dbug($e->getMessage());
     }

-  $name     = _("Unknown");
-
   foreach($ret as $key => $val){
     $name   = $val;
     break;

See: https://community.freepbx.org/t/callerid-lookup-module-no-longer-passing-default-caller-id-through/92948
Also: https://community.freepbx.org/t/callerid-lookup-module-update-issue-no-longer-passing-default-caller-id-through/82730

Operating Environment

FreePBX 16.0.40.4
CallerID Lookup 16.0.15

Relevant log output

152275[2023-11-28 15:40:22] VERBOSE[2847539][C-000001ff] res_agi.c: agi://127.0.0.1/dialparties.agi: Caller ID name is 'Unknown' number is '06991234567'
152276[2023-11-28 15:40:22] VERBOSE[2847539][C-000001ff] pbx.c: Executing [s@macro-user-callerid:48] Set("PJSIP/xxx-000006d6", "CALLERID(name)=Unknown") in new stack
152277[2023-11-28 15:40:22] VERBOSE[2847539][C-000001ff] pbx.c: Executing [s@macro-user-callerid:50] Set("PJSIP/xxx-000006d6", "CDR(cnam)=Unknown") in new stack
152278[2023-11-28 16:12:01] VERBOSE[2850025][C-00000201] pbx.c: Executing [s@macro-user-callerid:48] Set("PJSIP/xxx-000006dc", "CALLERID(name)=Unknown") in new stack
152279[2023-11-28 16:12:01] VERBOSE[2850025][C-00000201] pbx.c: Executing [s@macro-user-callerid:50] Set("PJSIP/xxx-000006dc", "CDR(cnam)=Unknown") in new stack