Giter Site home page Giter Site logo

Comments (3)

efb4f5ff-1298-471a-8973-3d47447115dc avatar efb4f5ff-1298-471a-8973-3d47447115dc commented on June 3, 2024

I almost consider this a bug but we didnt think about this in testing so i understand why you decided to create a feature request for this

from freetube.

jasonhenriquez avatar jasonhenriquez commented on June 3, 2024

I almost consider this a bug but we didnt think about this in testing so i understand why you decided to create a feature request for this

Yeah, I know it can get a bit sensitive/pedantic on what counts as a feature request versus a bug, so I wanted to prevent any potential mini-argument lol.

I am on a bit of a hiatus, but one way I could see this being implemented is by having a prop of the last non--1 videoIndexInPlaylistItems value and using that instead in watch-video-playlist's playNextVideo(). I'm sure there's a better way, but this is the first thing that came to mind.

from freetube.

jasonhenriquez avatar jasonhenriquez commented on June 3, 2024

I've tried thinking about this one tonight and have ended up in extreme overthinking territory. Note to the implementer on this one: please don't overthink, just do the suggestion above. It's impossible to not have things fall apart outside of much more than this one basic case because of the arbitrariness of "maintaining position" with deleted elements. Just do what I suggest above and eff the edge cases, because YT seems to fail so many of them on this specific issue in my testing (and rightfully so, because the non-basic cases are so rare).

from freetube.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.