frenetic-lang/ocaml-packet

Serialization for some common network packets, including ethernet frames, IP, TCP, and ARP.

ocaml-packet's Issues

Change "nw" to "ip".

The packet library uses the "nw" prefix to mean "ip". For example, the nwProto field refers to the packet's IP protocol.

The OpenFlow 1.0 spec, on the other hand, uses "nw" more broadly. The nw_proto field holds either the IP protocol or the lower eight bits of the ARP opcode, and nwSrc/nwDst either refer to the source/destination IP address in IP packets or the requesting/responding IP address in ARP packets.

We should change "nw" to "ip" and add ARP accessor functions (like isRequest/isResponse).

VLAN parsing ignores Drop Eligible Indicator (DEI) field

A VLAN-tagged packet has four parts:

• Tag Protocol Identifier (16 bits) - the constant 0x8100
• Priority Code Point (3 bits)
• Drop Eligible Indicator (1 bit)
• VLAN Identifier (12 bits)

Currently the code ignores the DEI, so if you construct a packet thinking that information's stored in the PCP (in the first bit), the library will not serialize the packet as you intended. If you're expecting a packet for which the DEI field is significant, it will be dropped and you will test against the first bit of the PCP.

Quickcheck tests for DNS

Need test cases for new functionality added in #6

Quickcheck tests for IGMP

Need tests for new IGMP functionality added in #3

Protocol Factorization (DNS)

I noticed that DNS packet processing was added in #6. Is there any plan for separating protocol parsers/marshalers into libraries of their own? We also have mirage/ocaml-dns which contains a number of missing features like packet decompression support.

Do you foresee ocaml-packet's protocols being factored into libraries of their own? Would you consider using some or all of ocaml-dns? If you're not satisfied with ocaml-dns (I'm not either...), what could change to make it more usable to you? Is there some common core of functionality that both projects could use? ocaml-dnsproto?