freshleafmedia/multi-list-control

multi-list-control's Issues

Search Only Searches On Previously Entered String

Currently the search as you type feature searches based on your previous string.

Eg: if you type in a, no search request is sent
if you type in ab, a search for a is sent
if you type in abc, a search for ab is sent
etc

Loading Feedback

Currently there is no feedback to the user that their search is running it just looks like nothing has happened

No Reason Given When Limit Reached

There is no reason given to the user when they reach the limit of the number of items they can select, while the search box is disabled there is nothing to tell you why.

Javascript Standards

Probably should use eslint or something

Partially Clearing Input Doesn't Cause A Search

If you enter testing into the search and then hit backspace or remove part of the search query a search query isn't sent

Race Condition

As there is no request cancellation or debouncing (#13) on the suggestion code it's fairly likely to get race conditions

Make work with integer keys

When the keys are integers, there are some type issues

Document how to include styles

Continuous integration to release versions to NPM

Dragging An Item Should Remove It From The List

When you drag an item the item that you're dragging should no longer appear in the list as you've 'picked it up'. If you don't you get weird things like you can drop the item above or below itself which makes no sense

String Localisation

Currently there is no way to translate any of the hardcoded strings (eg Search...). Maybe we could pass in an optional set of translated strings on initialisation?

JS Error On Drag

You get the following error when dragging items

TypeError: e.target.closest is not a function

Hitting Enter In The Search Doesn't Search

If you hit enter while focused on the search box it doesn't do a search and even worse if the select is part of a form the event can cause the form to be submitted

Prevent adding same file twice

You can currently choose the same file twice from the search suggestions

Searches Run On Non-Inputting Key Presses

If you are focused on the search box and you press keys that don't input text like <ctrl> + A a search is still run.

Easily fixed by replacing the keypress event with input

Add tests

Things to add tests for:

• Check that integer keys work

Add jsdoc

Add jsdoc to all methods, so we can mark up with types

JS Error on drag when there is only one item in the list

Cannot read property 'dataset' of null

Searches Appended To Suggestion List

When you do a search items are added to the suggestion list but then when you search again (or keep typing) the next set of results are appended to the current list so it looks like it isn't searching

List Not Initially Populated In FF

The list isn't initialised with the current list of items when you do a soft reload, in FF

Search Suggestions Doesn't Scroll To The Top

If you run a search and then scroll down the results then do another search the new results are loaded in but the suggestion box doesn't scroll back to the top

Decide on final name of component

Add option for changing 'No items selected' string

Suggestion Debouncing

Currently the search suggestions are run as fast as the user can type, there should be some debouncing to reduce queries sent

Focusing The Search Box Shows The Suggestions Panel Even When Empty

If you focus on the search box when you haven't previously done a search the suggestions box shows but as it's empty you just end up with a double border below

Release package to NPM

Dragging Items Is Jank When There Is A Scrollable List

If the list of items are scrollable then dragging an item up or down to scroll is really janky

Disable autocomplete on suggestions input

Add debounce to searching suggestions

Add examples page (ghpages)

Add github pages to demonstrate the plugin in action

Indentation Wrong

We're currently using 2 space indentation rather than the standard 4 spaces

Add 'grab' cursor when hovering over draggable items