Comments (14)
Do your contacts have the same phone number ? As a company number ?
Are they google contacts ?
Are they mobile phone number ?
Original comment by [email protected]
on 2 Jan 2011 at 6:52
- Changed state: Investigating
from gtalksms.
Jacob does not have a number. It shows him for every send.
He is a Facebook contact.
They are Google contacts with mobile numbers set.
Original comment by Eckankar
on 2 Jan 2011 at 7:00
from gtalksms.
Can you force contact sync in global parameters -> account & sync -> and
uncheck and check every field contact for each account.
After sync is ok reboot your mobile.
It's a weird bug because the contact request works fine for me with the same
configuration as you.
Original comment by [email protected]
on 2 Jan 2011 at 11:28
from gtalksms.
Looking a bit at the source code, my guess as to the source of the bug would be:
ContactsManager.getContactName(Context, String) assumes that the String
parameter is a phone number.
However, in MainService.java:506, setLastRecipient is called with a string
which isn't a phone number (in my case) and sets _lastRecipient to this. This
is in turn passed directly to getContactName.
The reason the message goes through and only the names fail is that the phone
numbers are looked up through ContactsManager.getMatchingContacts, which
performs the lookup in a different way altogether, while getContactName is used
for finding the display name.
That'd be my guess, at least. Haven't done any proper debugging.
Original comment by Eckankar
on 3 Jan 2011 at 12:07
from gtalksms.
Correct, good catch, I'll commit a fix for the next version. But it's weird
that getMachtingContact return a match in your case.
Original comment by [email protected]
on 3 Jan 2011 at 2:09
- Changed state: Started
from gtalksms.
It could possibly be because his mobile number is listed as "Askme".
Original comment by Eckankar
on 3 Jan 2011 at 2:11
from gtalksms.
Original comment by [email protected]
on 5 Jan 2011 at 8:42
- Changed state: Fixed
from gtalksms.
It hasn't completely fixed it.
The "Sending sms to XXX" message still is wrong.
Original comment by Eckankar
on 6 Jan 2011 at 7:22
from gtalksms.
Original comment by [email protected]
on 6 Jan 2011 at 8:48
- Changed state: Investigating
from gtalksms.
Is your phone number contact always set to "askme" ?
If you change it, does it fix your problem ?
Original comment by [email protected]
on 16 Jan 2011 at 12:46
- Changed state: NotReproduced
from gtalksms.
I'm a persistent bugger, so I'd rather find the bug than do a workaround. :)
ContactsManager:250, getContactName is called with contact.name, but it expects
a phone number.
That'd explain how MainService:853 and MainService:857 gets a wrong name for
phone.contactName.
Original comment by Eckankar
on 16 Jan 2011 at 1:44
from gtalksms.
oups I miss this one... I hope this time it's the good one!
Thanks for your help.
Fixed in next release.
Original comment by [email protected]
on 16 Jan 2011 at 3:05
- Changed state: WaitingForRelease
from gtalksms.
Fixed in 1.7.2
Original comment by [email protected]
on 16 Jan 2011 at 7:43
- Changed state: Fixed
from gtalksms.
Original comment by [email protected]
on 25 Aug 2011 at 7:51
- Changed state: Deployed
from gtalksms.
Related Issues (20)
- Attempting to connect after changing the connection settings results in a crash of com.ui.system HOT 2
- Ability to call public actions
- Control over more of the TTS parameters
- An accessibility service for literal control over the device
- No notifications on new SMS with new release HOT 16
- If write SMS db permission is not disabled, double SMS are in my log HOT 3
- Photo is not sent back via XMPP HOT 4
- Update German translation HOT 3
- xhtml don't work fine on bitlbee HOT 3
- Too many bytes sent per day HOT 1
- Commands not sending to phone. HOT 2
- Not getting alerts with 4.4.5 HOT 2
- Error writing to MUC: bad-request Invalid value for 'whois' HOT 5
- Mark as read does not work on Samsung Note 3 HOT 2
- Can't connect to jabber.org since 11/26 HOT 2
- remote access for Motorola moto g HOT 1
- reconnect on Google apps account does not respect custom server settings HOT 1
- Auto reconnect failing to google talk HOT 8
- File transfers not working
- GTalkSMS keyboard improvement HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gtalksms.