Giter Site home page Giter Site logo

Comments (7)

TruSteel avatar TruSteel commented on June 26, 2024

If you have a custome config for this site I would love to get it. Thank you

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on June 26, 2024

Hi @TruSteel, thanks for submitting a request for a new site. I took a look at it and think this config should work. If you have some time, please test it out and let me know how it works for you. If it works well, I'll add it to the official config as a supported site.

{
  "www.mgmplus.com": [{
    "className": "bmpui-subtitle-region-container",
    "displaySelector": "div.bmpui-subtitle-region-container",
    "mode": "element",
    "subtitleSelector": "span.bmpui-ui-subtitle-label > span",
    "tagName": "DIV",
    "videoSelector": "video#bitmovinplayer-video-player-container"
  }]
}

To use this config, paste it into the Custom Sites area (Options page > Audio tab) and click the blue "SAVE" button underneath it. Then, make sure to refresh the tab for the video site (if you have it open still) and it will load this new configuration.

For best results, make sure to remove any custom config used for testing like this once it has been included in the official update.

from advancedprofanityfilter.

TruSteel avatar TruSteel commented on June 26, 2024

Wow works great. Thank you very much.

from advancedprofanityfilter.

TruSteel avatar TruSteel commented on June 26, 2024

After testing a few more movies, still doing good except for the movie The Gambler, it would mute just before the curse word so you would still hear the curse word.

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on June 26, 2024

Thanks for the update @TruSteel! I found an instance around 1:00:25 where the timing was off on the captions and it did let a word slip through. Unfortunately the filter is only able to filter based on when the captions appear and are removed, so if their timings are off it can cause problems. One thing you can try is to change the Unmute Delay (Options page > Audio) to something like 0.5, which will keep it muted for half a second longer. This will only help in situations where the captions are appearing ahead of the spoken words, and thus unmuting too early. Unfortunately we can't go the other direction because we don't have the caption data in advance,

One thing to note about Unmute delay is that it will be used on all sites, so you may need to adjust it for specific movies, and then reset it back to 0 on others if the timing is correct.

from advancedprofanityfilter.

TruSteel avatar TruSteel commented on June 26, 2024

Thank you very much for your hard work and this info. I will definately give this a try.

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on June 26, 2024

This was added in Version 3.3.3.

If you used the "Custom config" in this issue, its recommend to remove the custom config once it has been included in the official update.

from advancedprofanityfilter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.