Giter Site home page Giter Site logo

Comments (7)

richardfrost avatar richardfrost commented on July 24, 2024

Hi @Jenron3000, thanks for reporting the issue. I'm glad that you are enjoying the filter when it is working for you though! Hopefully we can get it fixed up again.

It looks like Discovery+ has changed quite a bit about their website, but I do have a potential update that will hopefully fix it. Could you give it a try and let me know how it works for you?

{
  "www.discoveryplus.com": [
    {
      "className": "sc-iMWBiJ",
      "mode": "element",
      "subtitleSelector": "div.sc-ihgnxF",
      "tagName": "div"
    }
  ]
}

To use this config, paste it into the Custom Sites area (Options page > Audio tab) and click the blue "SAVE" button underneath it. Then, make sure to refresh the tab for the video site (if you have it open still) and it will load this new configuration.

If you do find an issue with it, please let me know what video and an approximate timestamp so I can make sure to get it fixed.

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on July 24, 2024

Sorry @Jenron3000, I did some more testing with that config I shared earlier and it definitely has some issues. This one should work much better:

{
  "www.discoveryplus.com": [
    {
      "apfCaptions": true,
      "apfCaptionsSelector": "div#overlay-root",
      "displaySelector": "div[data-testid=caption_renderer_overlay]",
      "mode": "watcher",
      "subtitleSelector": "div[data-testid=caption_renderer_overlay] div.sc-iMWBiJ div.sc-ihgnxF",
      "videoSelector": "div[data-testid=caption_renderer_overlay] video"
    }
  ]
}

from advancedprofanityfilter.

Jenron3000 avatar Jenron3000 commented on July 24, 2024

I tried dropping that code in and it still only blocks the caption and doesn't mute the audio. Should it change the code in the "supported sites config" list? after i save the code it doesn't change it.

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on July 24, 2024

Thanks for getting back to me @Jenron3000. Good question, but it won't change the "support sites config" in the list, those are just the built-in configs and are read-only.

I'm sorry, I just noticed both a typo and an error in the 2nd config I shared with you. Could you please try this one?

{
  "www.discoveryplus.com": [
    {
      "apfCaptions": true,
      "apfCaptionsSelector": "div#overlay-root",
      "displaySelector": "div[data-testid=caption_renderer_overlay]",
      "mode": "watcher",
      "subtitleSelector": "div[data-testid=caption_renderer_overlay] div.sc-iMWBiJ div.sc-ihgnxF",
      "videoSelector": "div[data-testid=video-container] video"
    }
  ]
}

Also, please make sure the site is set to normal (not Advanced or Deep).

If this one still doesn't work, can you share an example video so I can test it? Thanks!

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on July 24, 2024

@Jenron3000 When you get a chance let me know if this latest version works for you. Sorry again for the errors in the previous configs.

from advancedprofanityfilter.

Jenron3000 avatar Jenron3000 commented on July 24, 2024

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on July 24, 2024

Thanks for letting me know @Jenron3000.

This has been included in version 3.5.0 of the extension. For best results, make sure to remove any custom config used for testing like this once it has been included in the official update so you can automatically get future updates.

from advancedprofanityfilter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.