Giter Site home page Giter Site logo

Comments (6)

rneatherway avatar rneatherway commented on July 3, 2024

I'm pretty sure this is the offending code: https://github.com/fsharp/fsharpbinding/blob/master/emacs/fsharp-mode.el#L293

And it looks as though the other cases will have the same problem. I guess people don't use that function very often! A PR would be very welcome, or I will get to this in a bit.

from zarchive-fsharpbinding.

wk-j avatar wk-j commented on July 3, 2024

I just fixed the line you point and it work on my machine.

((equal ext "fs") (concat "\"" fsharp-compile-command "\"" " --nologo " file))

Thank you.

from zarchive-fsharpbinding.

rneatherway avatar rneatherway commented on July 3, 2024

I was just having a quick look and I think the more robust fix would be to replace concat with combine-and-quote-strings. Would you mind trying the line:

((equal ext "fs")  (combine-and-quote-strings (list fsharp-compile-command "--nologo" file)))

instead?

from zarchive-fsharpbinding.

wk-j avatar wk-j commented on July 3, 2024

All right, I tries your suggestion and it work well.
This's the first time I've edited lisp code.

Thanks

from zarchive-fsharpbinding.

rneatherway avatar rneatherway commented on July 3, 2024

Great, thanks for trying! I will fix this and roll it into the next release.

from zarchive-fsharpbinding.

rneatherway avatar rneatherway commented on July 3, 2024

Fixed in #1005

from zarchive-fsharpbinding.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.