Adding Glyph to Completion output in fsautocomplete

[Krzysztof-Cieslak]

Adding Glyph to Completion output in fsautocomplete

[7sharp9]

See:
https://github.com/fsharp/FSharpMDXS/blob/master/MonoDevelop.FSharpBinding/Services/LanguageService.fs#L124

On 17 May 2015, at 13:38, Krzysztof Cieślak [email protected] wrote:

Hello,

I would be interested in adding glyphs to output from completion command in fsautocomplete. This would allow me to provide richer autocomplete user experience in Atom (something like )

I've created basic implementation on my fork of project (master...Krzysztof-Cieslak:CompletionType) but it is "breaking" change so I don't know what is procedure for such case.

Also, is there anywhere list of possible glyph values?

—
Reply to this email directly or view it on GitHub.

[rneatherway]

@Krzysztof-Cieslak this is a nice idea, and I am completely open to breaking changes where they improve things. We should just inform the vim and sublime guys. Anyway, I have some good news, which is that this repo is being deprecated, and the FSharp.AutoComplete component as of this weekend lives over here: https://github.com/fsharp/FSharp.AutoComplete/. I've also just done a binary release as you asked: https://github.com/fsharp/FSharp.AutoComplete/releases/tag/0.14.0. This has a fsautocomplete.zip that you can drop in with your plugin.

So, if you could move this over to the new repo as a PR, with a bump to the version number (perhaps 0.15.0 as it changes the API) and run and check the tests that would be great. I wonder if it would be worth changing the Glyph property to a more usable string. Dave, I couldn't quite make sense of the link you posted, why divide by 6?

[7sharp9]

It uses bitfields, don't blame me the F# compiler stores it that way!

[7sharp9]

See: https://github.com/fsharp/fsharp/blob/259e855b69140995056c1f74d58a26b7071ccae5/src/fsharp/vs/ServiceDeclarations.fs#L1184

[Krzysztof-Cieslak]

Ok, so I'm closing this issue if we are moving repo.

[rneatherway]

@7sharp9 sorry wasn't blaming you! Thanks for the link.

[kjnilsson]

This is great - rather than returning the int representing the glyph could
we do the translation on the server side?

On Sun, 17 May 2015 at 23:37 Robin Neatherway [email protected]
wrote:

@7sharp9 https://github.com/7sharp9 sorry wasn't blaming you! Thanks
for the link.

—
Reply to this email directly or view it on GitHub
#1010 (comment)
.

[rneatherway]

@kjnilsson yes we are just discussing that over at the new PR ionide/FsAutoComplete#1