Giter Site home page Giter Site logo

Comments (7)

dsevastianov avatar dsevastianov commented on August 23, 2024

Where would you prefer to see it? I think it makes sense to have it on Execute, this way there is no need to repeat parameters for different connections.

from fsharp.data.sqlclient.

rojepp avatar rojepp commented on August 23, 2024

Sure, an optional param on Execute is fine. If you want to keep following what Sql TP is doing, you can do that too.
In that case, ditch the public constructor, and add the static GetDataContext() method for creating instances. That would also have the optional connstring param. Whichever way is fine with me.

from fsharp.data.sqlclient.

dsevastianov avatar dsevastianov commented on August 23, 2024

In the end, we decided to expose ConnectionString as property. This way it can be overridden right on constructor call. Does it make sense to you?

from fsharp.data.sqlclient.

rojepp avatar rojepp commented on August 23, 2024

@dsevastianov Sounds good, thanks!

from fsharp.data.sqlclient.

dmitry-a-morozov avatar dmitry-a-morozov commented on August 23, 2024

@rojepp I was thinking go back to your suggestion and make connectionString as optional ctor parameter for generated command class instead of property. It makes usage simpler and TP code cleaner. What do you think?

from fsharp.data.sqlclient.

rojepp avatar rojepp commented on August 23, 2024

Sounds good to me!
On Oct 22, 2013 3:46 PM, "Dmitry" [email protected] wrote:

@rojepp https://github.com/rojepp I was thinking go back to your
suggestion and make connectionString as optional ctor parameter for
generated command class instead of property. It makes usage simpler and TP
code cleaner. What do you think?


Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-26803795
.

from fsharp.data.sqlclient.

dmitry-a-morozov avatar dmitry-a-morozov commented on August 23, 2024

Connection string override as parameters to generate command type.

from fsharp.data.sqlclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.