Giter Site home page Giter Site logo

Comments (3)

vasily-kirichenko avatar vasily-kirichenko commented on August 23, 2024

I used static method because I didn't know it's possible to constrain on arbitrary constructor, not only on unit -> ^a. So, your solution is obviously better.

What about your main question, I really have no good ideas :( The best I managed to make is following:

module Settings = 
    let DB1ConnectionString = ""
    let DB2ConnectionString = ""

let inline create connStr : ^a = (^a : (new : string -> ^a) connStr)  

module DB1 =
    type Command11 (connString: string) = class end
    type Command12 (connString: string) = class end
    let inline create() = create Settings.DB1ConnectionString

module DB2 =
    type Command21 (connString: string) = class end
    type Command22 (connString: string) = class end
    let inline create() = create Settings.DB2ConnectionString

let cmd11 : DB1.Command11 = DB1.create()
let cmd12 : DB1.Command12 = DB1.create()
let cmd21 : DB2.Command21 = DB2.create()
let cmd22 : DB2.Command22 = DB2.create()

However, it's convention only. Nothing stops us to use wrong runtime connection strings :(

We need parameterized modules :) Or nested types :)

from fsharp.data.sqlclient.

dmitry-a-morozov avatar dmitry-a-morozov commented on August 23, 2024

Fixed in release 1.1.27.
In latest release command type gets static property called "ConnectionStringOrName" with value same as passed down to the type provider at design time. So now example of factory above can be update to

module Settings = 
    [<Literal>]
    let DB1ConnectionString = ""
    [<Literal>]
    let DB2ConnectionString = ""

module SqlCommand = 
    type Command1  = SqlCommand<"SELECT * ...", DB1ConnectionString >
    type Command2  = SqlCommand<"SELECT * ...", DB2ConnectionString >

    let inline create() : 'a = 
        let designTimeConnectionString = (^a : (static member get_ConnectionStringOrName : unit -> string) ())

           // i'll skip dot (.) int "ConnectionStrings.["DB1"]" because github code in-lining freaks out
            let db1ConnStr = ConfigurationManager.ConnectionStrings["DB1"].ConnectionString
            let db2ConnStr = ConfigurationManager.ConnectionStrings["DB2"].ConnectionString

        match designTimeConnectionString  with
        | DB1ConnectionString  -> (^a : (new : string -> ^a) db1ConnStr )    
        | DB2ConnectionString  -> (^a : (new : string -> ^a) db2ConnStr )    
        | _ -> failwithf "Unrecognized command type %s" typeof<'a>.FullName

(*
       or even
        let database = SqlConnectionStringBuilder(designTimeConnectionString).InitialCatalog
        if database = "AdventureWorks2012"
        then 
            (^a : (new : string -> ^a) adventureWorks)    
        else failwithf "Unrecognized command type %s" typeof<'a>.FullName
*)

Feedback on this new feature is welcomed.

from fsharp.data.sqlclient.

dmitry-a-morozov avatar dmitry-a-morozov commented on August 23, 2024

@vasily-kirichenko How do you like this new design?

from fsharp.data.sqlclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.