ftlabs/ftellipsis

Multi-line ellipsis made possible

ftellipsis's Issues

Child elements must be a block type and should not have any additional padding/margin styles.

Just a note, not sure if this is a bug or if the readme needs to be updated. I found that the child elements in the requirements don't work if they are span (so I'm guessing non-block type), or if they have any margin (so maybe any styles that mess with the line-height calculations). Figured I'd post it here in case someone else was trying to figure out why something wasn't working.

For reference, the browser I was testing this on was Chrome 74

Allow ftlabs npm account to publish new versions of ftellipsis on npm

I guess this is testament to the stability of this code, but over a year after the last release of this module it'd be kinda nice to release a new version that gives more useful error messages... @wilsonpage could you add us to the approved maintainers?

npm owner add ftlabs ftellipsis

https://www.npmjs.org/doc/cli/npm-owner.html

Long connected string causes issues

I had issues when I tested with a long connected string like this:
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

the issue is that it reserved the long text space however the displayed text is the desired result

IE9

In IE9, I'm getting this error on init:

SCRIPT5007: Unable to get property 'add' of undefined or null reference
ftellipsis.js, line 309 character 5

And in IE8, this is the error that gets thrown:

SCRIPT5007: Object expected
ftellipsis.js, line 64 character 5

Version mismatch

Line clamp doesn't go up when element gets taller

I have an element with a height that is getting changed dynamically when the window is resized. When the window gets shorter, the element gets shorter and the line clamp on the child elements goes down properly. When the window gets taller, however, the element gets taller but the line clamp does not go up. Here's a jsfiddle example.

Is there a way I can fix this with my code?

set()/unset() should bail if no child element will actually be clamped

This is as simple as adding || !this.child.el to the first lines of set and unset

Grunt readme generation broken

$ npm install
$ grunt
Running "uglify:build" (uglify) task
File "build/ftellipsis.min.js" created.

Running "readme:dist" (readme) task
Warning: Cannot call method 'forEach' of undefined Use --force to continue.

Aborted due to warnings.
$ grunt --version
grunt-cli v0.1.9
grunt v0.4.1

FWIW I'm on OSX 10.8.3,

Implement unit test coverage tooling and badging

Implement unit test coverage tooling and badging. Might be nice to add on the devDependencies badge too.

Doesn't work in Internet Explorer 11

What browsers are supported?