fullptr/apecs

A petite entity component system

apecs's Issues

Missing reference

Whenever you call the callbacks the code reads

        for (auto cb : std::get<std::vector<callback_t<Comp>>>(d_on_add)) {
            cb(entity, ret);
        }

where probably you'd want to use for( auto& cb : ... in order to not copy the callback object into cb.

Missing variable name

Line 573, which is in member function registry<Comps...>::view(), currently reads

            apx::entity = d_entities[index];

which I needed to change to

            apx::entity entity = d_entities[index];

in order to make it compile (with GCC10).

Missing template keyword

Hi, really like the minimalist approach of apecs!

I just tried compiling with GCC10 and stumbled over the following issue:

In template class handle the type of member field registry depends on the template parameters of handle.

In the member functions of handle that call registry->function<Comp>(...) it is therefore necessary to use the template keyword as in registry->template function<Comp>(...).

Incorrect use of move

In member function registry<Comps...>::add(apx::entity entity, Comp&& component) the argument component is passed on with std::move() even though Comp could be some_component_type&.

Since emplace() does it correctly you probably know that you just need to use std::forward instead, and can then remove the other overload of add(), the one with the const Comp&.