funwayguy/npc_integration

npc_integration's Issues

Dialogue Task not using the description

Ok, to get to the point, whenever I'm using the latest versions of better questing, custom NPCs, and their NPC integration, plus standard expansion mods, the description for the dialogue task doesn't work. For example, whenever I write something in the description box, the actual starting dialogue text appears (so what the person was going to say when interacted with) instead of the description.
All I did was create a dialogue within the global custom NPCs system, and put in the dialogue id, then the description. (These are also the latest versions on the Twitch launcher, which was in 1.12.2 and I used the up to date Minecraft launcher, or the newest. Which was also a singleplayer world)

Stoped server load after NPC Integration installed

I am using the latest version of BetterQuesting (3.0.322) with Standard Expansion (3.0.174 version) and everything works correctly on minecraft 1.7.10 version.

After installing NPC Integration (3.0.30 version) I get an error and the server stops. Text of error:
[Server thread/ERROR] [FML/]: Caught exception from bq_npc_integration
net.minecraft.server.MinecraftServer.getCommandManager()Lnet/minecraft/command/ICommandManager;

Trying to start a dedicated server without the world and I get the same error.

Because there is no crash I'm attaching a part of log with errors (and full mod list):
latest (2).log
Log on pastebin: https://pastebin.com/j6DW27Bi
I'm not posting a full log because not sure if 6k lines will be helpful.

Command block commands not trigger!

HI, if i type the command "/noppes npc Queen_Chloe delete" into the chat the NPC gets deleted but if i use it as a command reward, the NPC dosent get deleted. I have no idea what the issue is here. If i use /say she should be gone, this will come up in the chat like "[Better Questing]: she should be gone. maybe a bug or i do something wrong. Thanks for looking into it.

Dialog Task Not Triggering

I have a quest that is to trigger when Dialog ID 9 is complete, and it does not. This bug only appeared after last update.

[1.12.2] npc_dialog and npc_quest not working

Using:

• BetterQuesting-3.5.323
• CustomNPCs_1.12.2-(01Oct19)
• NPCIntegration-3.4.34.jar

When I create a dialog or a quest in CustomNPC and assign to a BetterQuesting quest, just dont recognize the ID and does not work. Will there be an update to make them compatible again?

[Question] 1.12

Any chance this mod will be updated to 1.12.x? Would be very useful in a modpack I am trying to create.

[Bug] Crash when trying to launch a new world

MC: 1.10.2
Forge: 2185, 2151
Mod: NPCIntegration-2.3.19

Issue: Instant crash on launch. Ticking memory connection. Same issue with Standard Expansion

Crash Log

Task:NPC_Quest giving the Task:NPC_Dialog instead

I'm getting a strange problem, that when I select the Quest Task it gives the me the Dialog Task instead. (Tested with the latest NPC Integration - 2.0.18, and Better Questing - 2.0.224)

If you could tell me if i'm doing something wrong, I'd appreciate it. And thanks again for making these amazing mods!

NoClassDefFoundError on Dedicated Server

Issue: 3.4.2.4 crashes dedicated server Forge 1.12.2 build 2705

Notes:
on startup, NoClassDefFoundError. All dependencies are installed. I suspect it's looking for a client side class.

crash report:
https://gist.github.com/c39d8e6f16157524ed4273c315931a47

fml server latest:
https://gist.github.com/5e828d5de10a9d7af6888f501a70efac

Crash with Version 1.0.7

My Modpack crash since i update NPC Integration form 1.0.6 to 1.0.7.

My Modpack:

https://github.com/GTNewHorizons/NewHorizons

https://gist.github.com/Dream-Master/3681865ea37764654cd3b114cb89b759#file-crash

Open Eyes said this:
http://openeye.openmods.info/crashes/b3c23c86f19593fb317981835c476ed2

Full fml log:
https://gist.github.com/Dream-Master/8f84c47c81243e5e5eeb6bc69c9fd07e

Title of the dialog not showing up.

HI,
I have installed
Better questing 3.5.289
Better questing - NPC Integration 3.4.27
Better questing - RF Expansion 3.4.27
Better questing - Standard Expansion 3.4.149
Cusom NPC's 1.12.2(26aug18)

I created a Dialog for an NPC from Custom NPC's and then i created a task in the Better questing book.
I looked up the ID of the Dialog and used this ID in the Task. The Title is not showing up in the book, only a Text "Dialog: [?]" is showing up. I tried everything the same in the 1.10 version of minecraft and the problem dosent exist there and i did everything the same way as in the 1.12.2 version. This might be a bug??

Client Crash

This happens only when logging on to a server. Updated quest database by using the command and now I crash when clicking on a particular quest. Any idea of why this might be happening?

https://pastebin.com/mm25hKR0

Dialog Task Triggering

MC 1.12.2
CustomNPC 09Jul18
Better Questing 3.5.262
Better Questing NPC 3.4.25

Using the built in Dialog from CustomNPC, I created a Dialog Task in the QuestBook. The event should fire after speaking to an NPC after Dialog 2, "Ask about village"
But it triggers constantly as this quick video shows.

I know the quest is set to repeat (cooldown of 1) but not until Ive spoken to the NPC ?

Crash adding NPC faction task.

Added a quest task for an NPC faction, as soon as I closed out of the edit to see the quest, this:

java.lang.NullPointerException: Rendering screen
at noppes.npcs.controllers.PlayerDataController.getDataFromUsername(PlayerDataController.java:47)
at bq_npc_integration.client.gui.tasks.GuiTaskNpcFaction.drawBackground(GuiTaskNpcFaction.java:37)
at betterquesting.api.client.gui.GuiScreenThemed.drawBackPanel(GuiScreenThemed.java:96)
at betterquesting.client.gui.GuiQuestInstance.drawBackPanel(GuiQuestInstance.java:129)
at betterquesting.api.client.gui.GuiScreenThemed.func_73863_a(GuiScreenThemed.java:108)
at net.minecraftforge.client.ForgeHooksClient.drawScreen(ForgeHooksClient.java:382)
at net.minecraft.client.renderer.EntityRenderer.func_181560_a(EntityRenderer.java:1094)
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1076)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:371)
at net.minecraft.client.main.Main.main(SourceFile:124)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:236)
at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:297)
at org.multimc.EntryPoint.listen(EntryPoint.java:162)
at org.multimc.EntryPoint.main(EntryPoint.java:53)

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Client thread
Stacktrace:
at noppes.npcs.controllers.PlayerDataController.getDataFromUsername(PlayerDataController.java:47)
at bq_npc_integration.client.gui.tasks.GuiTaskNpcFaction.drawBackground(GuiTaskNpcFaction.java:37)
at betterquesting.api.client.gui.GuiScreenThemed.drawBackPanel(GuiScreenThemed.java:96)
at betterquesting.client.gui.GuiQuestInstance.drawBackPanel(GuiQuestInstance.java:129)
at betterquesting.api.client.gui.GuiScreenThemed.func_73863_a(GuiScreenThemed.java:108)
at net.minecraftforge.client.ForgeHooksClient.drawScreen(ForgeHooksClient.java:382)

-- Screen render details --
Details:
Screen name: betterquesting.client.gui.GuiQuestInstance
Mouse location: Scaled: (360, 405). Absolute: (721, 37)
Screen size: Scaled: (720, 424). Absolute: (1440, 847). Scale factor of 2

this is using your alpha version you provided for me to test 2.3.20, also does not save but does crash each time I try to create a faction quest.

Quest Completion

Mod Version: 1.0.8
Issue: Quest completion not registering

Description: So when setting up quests in CustomNPC's completing a quest is not triggering the completion in Better Questing. Does not seem to be reading the quests in the NPC folder.

Server version don't work

You use directly

QuestController.instance.quests

But this code can be used only on server side. Please, use server-client logic. For example, you can see my version.

Crash on GUI open

Getting an odd crash to desktop when on a server and trying to open the better questing GUI to edit:

http://pastebin.com/91YUww66

Using newest versions of Better Questing, Standard Expansion and NPC integration, does not seem to happen in SSP only SMP

Faction Reward

I have three quests giving the same amount of faction reward. i.e. each quest gives 50 points to Fame. When I completed all three I only received 50 Fame total.

Faction Data

When using the task NPC Faction, any updates to faction data via custom npcs is not recognized by better questing unless I log off and on again. i.e I complete a quest that gives me +50 faction points as a reward and then want to complete another quest that requires 50 faction points to complete, it will not check the data (even when I press detect/submit) unless i log off and on.

[1.7.10] Can't read from or write to faction data

This is with the backported 1.12 version (3.0.30). NPC factions show up as [?] in the display and points can't be added to them or deducted from them.

Hunt Task not saving NPC data

I have noticed that randomly certain hunt quests I have added using CustomNPC's and edited NBT data for the name and skin keep reverting to a minecraft zombie.

EDIT: Have even tried deleting and re-adding task, same result

Task options don't save, tasks can't be deleted, and other stuff

Task:Dialog text entry never exits, and never saves.
I type anything into the options for the NPC Dialog task, it does not save.
Also if I click into the first option's text entry, and then click into the only other options text entry,
both will remain focused and anything I press/type goes into both fields.
And all changes to the task's options are completely ignored,
and always revert to the default.
Also when I click the little red x to delete the task, absolutely nothing happens.
Meaning I am unable to delete the Dialog Task.
Same things happen for the other NPC Integration tasks.
With the addition of the NPC Quest task turning into a Dialog Task when I try to delete it.
Oh, and this is on a server running Dev_005 build of my modpack.
https://www.atlauncher.com/pack/TownshipFarms/