fusionjs/fusion-plugin-i18n

Migrated to https://github.com/fusionjs/fusionjs

FUSION.JS

Modern framework for fast, powerful React apps

What is it?

fu·sion — noun

The process or result of joining two or more things together to form a single entity.

Fusion.js, Uber’s open source universal web framework, represents the fusion of the client and the server. It's geared for server-side rendering out of the box, and its plugin-driven architecture allows for complex frontend and backend logic to be encapsulated in a single plugin:

import App from 'fusion-react';
import Router from 'fusion-plugin-react-router';

export default () => {
  const app = new App(<div>...</div>);

  /*
  One line of code sets up everything you need for routing:
  - Server rendering
  - React Providers on both server and browser
  - Bundle splitting integration
  - Hot module reloading support
  */
  app.register(Router);

  return app;
}

We initially built Fusion.js to make our own websites easier to maintain, but were so impressed with the benefits that we decided to offer it to the community as an open source project!

Try it out

If you're interested in giving Fusion.js a shot, Overview and Core Concepts are great places to start.

Contributing

This is a monorepo of all open source Fusion.js packages maintained using Yarn v2. Take a look at CONTRIBUTING.md for info on how to develop in this repo.

License

MIT

fusion-plugin-i18n's Issues

Upgrade fusion-test-utils to 0.4.2

Update the TranslationLoader api to match the standard of using from(ctx)

Greenkeep

Error in newer versions of Flow

I believe this occurs for 0.80 and greater. I'm using 0.82.

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ node_modules/fusion-plugin-i18n/src/types.js:22:12

Cannot use function type as a type because function type is a value. To get the type of a value use typeof.

     19│ export type I18nDepsType = {
     20│   fetch?: typeof FetchToken.optional,
     21│   hydrationState?: typeof HydrationStateToken.optional,
     22│   loader?: I18nLoaderToken.optional,
     23│ };
     24│
     25│ export type I18nServiceType = {

Fix flow types

[TODO] don't append prefix if injected fetch also injects prefix

Update dependencies

Update dependencies

Loader isn't loading non en-us translations

Type of issue

Bug

Description

Loader is trying to load en_au.json but the file is en-au.json

Current behavior

Translations aren't loaded

Expected behavior

Translations should be loaded

Steps to reproduce

1. Use a non en-us locale

Your environment

• fusion-plugin-i18n version: 1.0.2

• Node.js version (node --version): 8.9.4

• npm version (npm --version): 5.6.0

• Operating System: OS X

Migrate fusion-plugin-i18n to createPlugin

Add Token dependencies to readme

Problem/Rationale

Documentation regarding Fusion API is out of date given recent changes to leverage new Dependency Injection architecture.

Solution/Change/Deliverable

Update documentation

Export the string interpolation function

Feature request

Export the string interpolation function for applications to use the same logic when interpolating strings externally.

We recently updated the interpolation logic to be able to pass interpolation variables through in order to interpolate externally. This is useful for interpolating dynamic values into translation strings. Because this use case happens mixed with internally interpolated translation strings, being able to use the exact same logic in both places would help guarantee consistency of outcomes.

Related, if the plugin architecture or performance considerations allow, it would be easier to maintain the code and internal consistency if we extract the translation function from browser and node implementation into its own file and re-use that.

Would like to hear any concerns, specially on the architectural or performance constraints to extract the translation function. Based on those, I am happy to contribute the update.

Middleware should add html lang attribute

Type of issue

Feature Request

Description

We should probably have the i18n plugin add the lang attribute to the opening html tag, as it is recommended for accessibility. We can do this using ctx.template.htmlAttrs

Don't interpolate if interpolation value is not present.

Currently, a call to translate() will attempt to interpolate variables even if no interpolation values are provided returning a string interpolated with "undefined".

This result is unexpected and it would be preferable to return a string with the variables in it. Such string is useful when you want to interpolate the values somewhere else in the application.

For example:

translations: {interpolated: 'hi ${adjective} ${noun}'},

translate('interpolated', {adjective: 'big', noun: 'world'}) 
// 'hi big world'

translate('interpolated', {noun: 'world'}) 
// 'hi ${adjective} world'

translate('interpolated')
// 'hi ${adjective} ${noun}'

Client-side locale switching

Currently there's no mechanism for client-side locale switching, which means a page refresh is required to change locales.

Perhaps there should be an API for doing this client-side.

Add initial implementation

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Preset name not found within published preset config (monorepo:angularmaterial). Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

Use Buildkite and Docker for CI

Migrate to new fusion-tokens api

[TODO] refactor i18n-related babel plugins out of fusion-cli package

Add better error messages surrounding problems with loading hydrationState

Migrate fusion-plugin-i18n to DI