fustrate/baseballbot.io

WIP rewrite of /u/BaseballBot

BaseballBot.io

baseballbot.io's Issues

Calendar Doesn't Detect Delayed Games

See title.

I think the issue is that the game_status_ind value sometimes includes a character denoting the reason for a delay. For example 'DR' may translate to 'Delayed due to Rain'.

Here's a potential fix:

# lib/baseballbot/template/sidebar/calendar.rb
# Line 234

# Old
return 'Delayed' if game[:status_code] == 'D'

# New
return 'Delayed' if game[:status_code].start_with? 'D'

Found the issue when looking at the calendar on /r/CHICubs and noticing that the April 5th game hadn't been updated.

Game Graph & Strikezone Map Links use UTC for Date Parameter

There is an issue in the Game Graph and Strikezone Map links.

The date parameter in the URL is a date value based on UTC time, so a 7PM CDT start time will pass tomorrow's date and that results in an error when visiting the link.

You can see what I am talking about if you look at today's game thread here, the links are:

http://www.fangraphs.com/livewins.aspx?date=2021-05-15&team=Astros&dh=0&season=2021
http://www.brooksbaseball.net/pfxVB/zoneTrack.php?month=05&day=15&year=2021&game=gid_2021_05_14_texmlb_houmlb_1%2F

The correct links are:

http://www.fangraphs.com/livewins.aspx?date=2021-05-14&team=Astros&dh=0&season=2021
http://www.brooksbaseball.net/pfxVB/zoneTrack.php?month=05&day=14&year=2021&game=gid_2021_05_14_texmlb_houmlb_1%2F

At game time the correct link will yield the expected content, but the bad link will return the error page.