This repository has been moved into a component of foxbox. Please submit your issues and your pull requests to that repo.
fxbox / openzwave-adapter Goto Github PK
View Code? Open in Web Editor NEWThis is the foxbox adapter for openzwave
This is the foxbox adapter for openzwave
This repository has been moved into a component of foxbox. Please submit your issues and your pull requests to that repo.
We use usize currently but we should use a typed structure wrapping the usize instead, to take advantage of the language's type safety.
https://github.com/fxbox/openzwave-adapter/pull/11/files#r59372179
I think that we should be filtering the getters and setters that we present, especially for the Door Lock
We should cleanup the value_cache HashMap at ValueRemoved and NodeRemoved.
https://github.com/fxbox/openzwave-adapter/pull/11/files#r59372513
The SendDirection enum has not a proper name, we should find a better one.
https://github.com/fxbox/openzwave-adapter/pull/11/files#r59371628
Currently we only save the network when the OpenZwave object is dropped. But this is very difficult to do so we should save the network at the right moments:
stop
is calledCurrently we store the full value in the value_cache but we only need to know in which range it was.
https://github.com/fxbox/openzwave-adapter/pull/11/files#r59372881
This was fixed by #4 but we need to look at these notifications more closely.
We add more things in the HashMaps but never clean them up.
Also the behavior using Weak and Arc looks fragile: if a watcher is added twice using a clone, then the Arc will be there twice, and the Weak would still be able to access the watcher after removing one of them. This doesn't seem to be a big issue ATM because we have one Arc per element added but this is a conceptual issue in our structures.
https://github.com/fxbox/openzwave-adapter/pull/11/files#r59372280
We need more documentation in this crate.
https://github.com/fxbox/openzwave-adapter/pull/11/files#r59371734
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.