readme.md example DataObject class code bug

[HARVS1789UK]

readme.md example DataObject class code bug

[g4b0]

@muskie9 what do you think about that? It seems reasonable, isn't it?

[muskie9]

I think that's fine for the example code. I would suggest though that if you aren't going to be running anything in the closure other than return true; to not include getSearchFilterByCallback() on the object as it may have unintended results since it's a hard true.

[HARVS1789UK]

Hi @muskie9

Agreed, now that I have read through the code and seeing a check is made to see if the method exists I could just as easily remove the getSearchFilterByCallback() method from my DataObject (which I will probably do).

Just thought I would raise the potential time saver in the example code in README.md as I expect that many users of the module will (like me) be lazy and copy the example code to get the module up and running ASAP and many of them may also spend some time wondering why their DO's are still not showing up in search. Up to you guys if you want to make the change or not, just thought id suggest it.

Kind regards,

HARVS1789UK

[muskie9]

I think it's a good suggestion, probably a good idea to describe filterByCallback() usage a bit as well. I started looking around the SilverStripe docs but there's nothing in there that I could find for that filter type. Only a single example in the API.