SS 3.3.1: tons of "Title" indexes

[wernerkrauss]

SS 3.3.1: tons of "Title" indexes

[wernerkrauss]

I wonder why it was fixed in 2.1.3 but is not in dev-master...?
b8b0bfe

Which brings me again to #26 - why not just use a DO for saving the search - this way you can use extensions for additional search information and SS will handle the index creation.

[g4b0]

Yes, maybe #26 should be the right way to handle it. A PR would be really appreciated :D

[rotassator]

My take on fixing this that also works in SQLite - #38

why not just use a DO for saving the search
I thought about this, but AFAIK the ORM would use the ID for the lookup and break since the primary index is on ID + ClassName.

[g4b0]

@wernerkrauss are you ok with the new PR?

[wernerkrauss]

I hope I can have a look at at this weekend. Looks good but would need some testing...

Just wondering if i can write a unit test for that?

[g4b0]

Sure you can! This module is growing and some unit test shoud be very useful. We can then also try to integrate some CI like travis, but first we need some test :)
Thanks a lot, I will be very happy to merge your PR

[g4b0]

@wernerkrauss does this PR solve your issue? Can we close the issue?

[wernerkrauss]

@g4b0 Seems it fixed the problem. I ran a quick test, deleted the actual SearchableDataObjects table and it created only two indexes, Title and Content. Tested with dev-master d2e02b7

Thanks!

[g4b0]

thanks to you and @rotassator