gabrieljackson/mattermost-plugin-wrangler

Manage Mattermost Messages Masterfully!

mattermost-plugin-wrangler's Issues

It is very difficult to work with

Hello friends
It is very difficult to work with this plugin
Please include a video tutorial

Thankful

Forwarding a message to another person

Hello to all friends

The "Wrangler" plugin can only be used to move and copy messages to other channels !!...

Forwarding a message to another person is one of the requirements for your messenger...

Add suggest feature, which would allow the original poster to approve a move.

Feature request to enable suggested moves.

/wrangler suggest move thread [MESSAGE_ID] [CHANNEL_ID]

would send a suggestion to the original poster to move the thread. The original poster could use

/wrangler approve [suggestionID]

Style select boxes with user's theme

Using a ReactSelect component, we can compose the select component with the user's theme. See the example in the Jira plugin here https://github.com/mattermost/mattermost-plugin-jira/blob/72786004625d83fc6580826268e0206dc157bb50/webapp/src/components/react_select_setting.jsx#L143

Inexplicable error message

I tried to post a post (thread) from a direct message channel to a private channel within the same team. However, I get the error message:

"Wrangler is currently configured to not allow moving messages to different teams"

Have the choice to post or not post the original message in the source channel when moving

If we are moving a thread from a public channel to a private channel in order to conceal a security issue for example, it may be an issue that the root message is posted by the Wrangler bot at the channel of the original post. We could have a checkbox in the modal that says "include root message in notice" or something similar.

Allows selecting the channel to move a thread to via channel name

Instead of having to look up the channel id, a user should be able to select the channel by name, e.g. /wrangler move thread [MESSAGE_ID] ~town-square.

Allow System Admin or Team Admin to use Wrangler

For now, plugin access is allowed for either all users or users with the "Allowed Email Domain". It could be nice to allow it to System Admin or Team Admin.

For example, we can choose in the settings between "Allowed Email Domain", "System Admins", "System and Team Admins" or "All users".
For Team Admins, it may be trickier : are they authorised to move a thread from a team to another ?

User receives error when trying to wrangle post in a thread, if not in the same channel as the current center channel

If I am trying to wrangle a post from a thread in "Channel A" to "Channel B", the plugin won't allow me to do this from the RHS unless "Channel A" is the current channel in the center channel pane.

Webapp crash on render error

An error occurred where team was undefined in this loop:

mattermost-plugin-wrangler/webapp/src/components/move_thread_modal/move_thread_modal.tsx

Lines 229 to 237 in d137cb1

	>
	{this.state.allTeams.map((team) => (
	<option
	key={team.id}
	id={team.id}
	value={team.id}
	>
	{team.display_name}
	</option>

I don't have consistent repo steps. It first happened when I exited the system console to go back to a team. There is an archived team on the instance if that could be affecting this.

More than one Allowed Email?

Hello,
Is it possible to add two or more allowed emails (with different domains) to use this plugin?

So, for example:

• [email protected]
• [email protected]

Best regards :)

Users get a white screen on browser & app when activated in 7.1/7.2

Some users are experiencing a white /empty screen with Wrangler enabled in 7.1/7.2

I disabled all plugins & enabled them one-by-one. Apparently, when enabling Wrangler the issue came back.

Server logs are empty. The issue doesn't affect all users, but I got messages from at least three.

Show channel display name instead of ID in the Wrangler moved thread summary

Today, the channel's real name is displayed instead of the display name of the channel in Wrangler's summary box (see screenshot).

The field that says town-square in this screenshot should instead display the Display Name of the channel.

Allowing customizable Bot-Messages

After attaching a message to a thread or moving/copying a thread, a bot message is sent to the author of that message.

Problems with that message:

1. The message is not customizable.
2. someone wrangled one of your messages is very unclear. For non native speakers and people not knowing about "wrangler", this message does not make sense.
3. It is not clear which moderator moved the message. Therefore not allowing the author to contact the executing moderator.

Possible fix:

1. It would be nice to change someone to the name of the executing moderator.
2. It would be nice to make the message customizable.

`/wrangler list messages` missing indentions on messages with returns.

Summary

When using /wrangler list messages, and a message has a return, account for the additional spaces needed to indent by len(UID) + len(" -")

Additionally, add a test for this situation.

RPC call OnConfigurationChange to plugin failed

Hi

I uploaded the plugin to my 5.19.0 instance and activated it. The plugin is showed as running and i can see it in the process list.

But when i type /wrangler it doesn't show up.

In the logs i see this:

{"level":"error","ts":1579872782.813044,"caller":"mlog/log.go:174","msg":"RPC call OnConfigurationChange to plugin failed.","plugin_id":"com.mattermost.wrangler","error":"connection is shut down"}

Commands: allow links to be used in stead of message IDs.

The Wrangler-UI and Mattermost's built-in moderation tools are currently not usable on mobile. The only way to move/copy messages on mobile is to use Slash-Commands. An example command would be /wrangler attach message message_id_1 message_id_2.

The only way to get those message IDs on mobile is to use the built-in 'copy link' feature. It gives a link like https://instance_url/team_id/pl/8w89igrsffyt3ghmwsmsgyeoqe. To use that ID for the command, a big part of that link has to be removed manually. It has to be done two times on small displays, and scrolling is quite tedious.

I would suggest allowing the use of URLs as parameters as well. With a simple regex, the URLs could be validated and edited to get the ID of the corresponding messages. This would greatly increase the usability of this plugin.

I am down to create a PR with these changes in the upcoming days if there are no reservations against it.

This plugin failed to start. Check your system logs for errors.

Trying to enable the plugin but getting an error "This plugin failed to start. Check your system logs for errors."
Running MM 7.0.0

Wrangler creates http instead of https addresses

Hi,

when I move a message to another channel, the system message reports:

A thread has been moved: http://mm.ourdomain.de/zgk/pl/zc7spc9a7fg4ubskes5piutwgo

The correct address however, is httpS:///mm.ourdomain.de/zgk/pl/zc7spc9a7fg4ubskes5piutwgo As a result, when clicking on the link in the Mattermost desktop app, the newly created message is not opened in the app but in the standard browser.

When I edit the message manually (http://... > https://...), I'm led correctly to the message within the app.

As I am not an administrator, I don't know whether the issue is a matter of the wrangler extension or our configuration. Can anyone give me a hint whether this is a bug or our administrator must change something in the configuration file?

Frank

Command with a trigger of '/wrangler' not found

Hello

We encounter some problem as explained at https://forum.mattermost.org/t/wrangler-plugin-not-working/12073
we have installed , enabled, configured plugin and trigger is not available. We have enable all features to be more laxist and prevent any restriction but nothing.
Any idea to solve this ?

Thanks a lot

testify/mock.AnythingOfTypeArgument is deprecated

I'm a co-maintainer of github.com/stretchr/testify. In v1.9.0 we have deprecated mock.AnythingOfTypeArgument.

I had a look at this project. All instances of mock.AnythingOfTypeArgument must just be replaced by mock.AnythingOfType. That fix will work both with v1.9.0 and with previous releases of testify.

All limited channel members can move posts with the Wrangler plugin !!!!!

Hello to all friends

All limited channel members can move posts with the Wrangler plugin !!!!

This has caused problems in our management channel several times ....

Please fix this

Thankful

@gabrieljackson @jfrerich

Option to disable bot notification message?

I would like to ask if the bot has an option (or if there is a consideration to provide an option) for users to copy messages/threads to a channel, and disable the notification message that comes with the copied message.

I probably understand that there is reason to keep the message (for privacy notice), and keeping the bot notification message on the original channel/PM is fine.

However, I am wondering if there is an option to disable the message that is attached to the copied message/thread on the receiving channel?

For example, my core use case for this bot is whenever a person leaves the organisation, we want to copy the history and paste it to a channel, so that the person taking over can have a knowledge transfer. However, with so many threads being copied, the whole channel seems flooded with notification messages from the bot.

Would like to know your thoughts on this feeedback/suggestion too.

Add plugin config option to permit/deny moving threads from private channels

Being able to move threads from private channels is intended behavior for the wrangler plugin, but it would be nice to have a config option to control this behavior.

Bug: opening dropdown on a system message crashes the webapp

When opening the dropdown menu on a system message, the webapp crashes

Reproduce

1. Enable the Wrangler webapp functionality [BETA]
2. Refresh the webapp
3. Click on the dropdown for a system message (i.e. "@someUse has joined the channel")
4. The screen becomes white
5. Refresh to restore the webapp

Webapp logs

TypeError: can't access property "user_id", n is undefined
    lt com.mattermost.wrangler_451a6ce528877b61_bundle.js:26
    Redux 5
    React 2
    k Redux
    React 9
    unstable_runWithPriority scheduler.production.min.js:19
    React 15
    unstable_runWithPriority scheduler.production.min.js:19
    React 2
    j scheduler.production.min.js:17
    onmessage scheduler.production.min.js:14
    EventHandlerNonNull* scheduler.production.min.js:13
    Webpack 13
react-dom.production.min.js:209:194
[Util] handleError::  TypeError: can't access property "user_id", n is undefined index.js:158:36
Uncaught TypeError: can't access property "user_id", n is undefined

Add plugin config option to permit/deny moving threads from DM channels

Being able to move threads from direct message channels is intended behavior for the wrangler plugin, but it would be nice to have a config option to control this behavior.

Build fails with invalid sass loader options

With node 14 on OSX, make dist eventually failed with:

ERROR in ./src/components/left_sidebar_element/style.scss (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[1].use[2]!./src/components/left_sidebar_element/style.scss)
Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
ValidationError: Invalid options object. Sass Loader has been initialized using an options object that does not match the API schema.
 - options has an unknown property 'includePaths'. These properties are valid:
   object { implementation?, sassOptions?, additionalData?, sourceMap?, webpackImporter?, warnRuleAsWarning? }
    at validate (/Users/dgittins/code/github/mattermost-plugin-wrangler.git/webapp/node_modules/schema-utils/dist/validate.js:105:11)
    at Object.getOptions (/Users/dgittins/code/github/mattermost-plugin-wrangler.git/webapp/node_modules/webpack/lib/NormalModule.js:527:19)
    at Object.loader (/Users/dgittins/code/github/mattermost-plugin-wrangler.git/webapp/node_modules/sass-loader/dist/index.js:25:24)

I was able to make the build complete with this patch:

diff --git a/webapp/webpack.config.js b/webapp/webpack.config.js
index 0fd7126..042899d 100644
--- a/webapp/webpack.config.js
+++ b/webapp/webpack.config.js
@@ -38,7 +38,9 @@ module.exports = {
                     {
                         loader: 'sass-loader',
                         options: {
-                            includePaths: ['node_modules/compass-mixins/lib', 'sass'],
+                            sassOptions: {
+                                includePaths: ['node_modules/compass-mixins/lib', 'sass'],
+                            },
                         },
                     },
                 ],

Is that the correct fix...?

Give option for more discreet notification when a thread is moved

The bot's message when a thread is moved to a different channel takes a lot of space, it would be great if there was a way to have it be just a simple message that says "A thread has been moved to this channel" (and "this channel" could be hyperlinked to the thread's new location). If folks find it helpful to have all the information that is currently included in the message, this could be set in a plugin setting to show a short or long notification message.

Add plugin config option to permit/deny moving threads from GM channels

Being able to move threads from group message channels is intended behavior for the wrangler plugin, but it would be nice to have a config option to control this behavior.

When a post is moved that begins with a header, the reply post by Wrangler renders the whole post as a header

Newly created channel does not show in Move Thread modal

Repro steps:

• Create a new channel
• Navigate to a different channel where a post exists
• Click the Wrangler's post dropdown menu item
• Observe that the new channel made does not show in the modal's dropdown

Refreshing makes it so the new channel appears in the modal

Add to Plugin Marketplace

This is an awesome plugin that has already helped with maintain a clean message flow on the Community Server.

As discussed offline, this would be a great addition to Plugin Marketplace. Would you be interested on submitting your plugin ? You can find the process for submitting your plugin here.

Plugin resources are loaded from mattermost domain disregarding context path

I have a Mattermost server behind nginx with a URL with a context path, eg https://MY-DOMAIN/mattermost/ (and Mattermost works fine)

When mattermost loads, I see the following URL in developer console with a 404:
https://MY-DOMAIN/plugins/com.github.matterpoll.matterpoll/api/v1/configuration

But it should be:
https://MY-DOMAIN/mattermost/plugins/com.github.matterpoll.matterpoll/api/v1/configuration

I am using the recommended nginx proxy configuration which does not cover /plugins (nor should it). Since I have a context path, my nginx location block is set to location /mattermost { .... The mattermost system console has the site url set with the context path.

Wrangler commands still work, but the UI does not load. I've attempted to temporarily add /plugins to the nginx proxied URLs, and the resource is then loaded correctly. I still did not discover any Wrangler UI (but I don't know where to look).

• Mattermost Server 7.5.2
• Wrangler Plugin 0.7.0

With Mattermost v7.1 the reactions table has a channelid column

When a post or thread is moved all of the associated reactions need to have their channelids updated.

Attaching a thread to a thread

This is a feature request.

In some cases, some people reply by using a thread, but others do not use the thread. As a result, there are some small parts of threads which should be merged into one thread.

I tried to check if this is possible with this plugin, wrangler. Attaching a message in a thread is unavailable from the UI button, but I could move the message by the slash command. But, in this case, associated messages following the moved message was removed completely.

Again, my suggestion is that enabling to attach a thread to thread from both the slash command and UI button is really useful to maintain the message flow in the channel.

Wrangling a post does not bring followers over to the new thread

When a thread is wrangled, the followers are not respected, so if I was following a thread in channel A and it's moved to channel B, I stop following it. It would be nice to re-add the old followers to the new thread.

Move Channel to Another Team?

Wrangler can move a Thread from one Channel to another.
Is it possible to move a Channel from one Team to another?

Moved post does not include uploaded files or copy-pasted images

Any uploaded files such as images or audio are not present in the resulting post of moving a message. I think this can be fixed by pointing each file object to the respective new post that it was originally associated with.

I18n for the Wrangler

First, I want to thank you for this plugin, the work-in-progress UI is great and the features are really useful. And they are especially with new-comers, who haven't really understood the functioning of Mattermost WRT threads and channels.

And so, as these new comers aren't often comfortable with English when it's not their primary language, it could be great to have the "A thread has been moved" and "Someone wrangled one of your messages into a thread for you" messages translated for the user.

Messages cannot be moved

A message to contact the admin is displayed.

The following messages are printed to server log:

error [2022-08-16 08:52:26.639 +02:00] unable to re-upload file: DoUploadFile: File rejected by plugin. File Blocker plugin - There was an error retrieving the session information, caller="app/plugin_api.go:975" plugin_id=com.mattermost.wrangler

We've got the Flie Blocker plugin active, but never got any problems inserting images. This could be related to image files handled differently, when pasted/uploaded in contrast to be moved by Wrangler.