gaelmare/dynamictreestfc

Dynamic Trees and TFC!

dynamictreestfc's Issues

Doesn't Work with latest Dynamic Trees Version

I just tried this with the latest available versions of Dynamic Trees and TerraFirmaCraft, and it crashed with this log:
https://pastebin.com/mK35Ugzs

Rooty block decays to dirt from rock layer 1, no matter what y-level

Should either check y-level for which dirt type it would be, or store it. Would require a tileentity or NBT for every placed rooty block to store the dirt type.

Rooty Dirt should have rooty texture overlay

Digging out the rooty blocks takes a long time, even though it just looks like a dirt block. Even grass blocks should have the DT rooty texture overlay so this isn't as much a surprise.

Overlay is in textures/blocks/rooty/roots.png.

chestnuts seeds should be roastable then edible

Only one tree block gets destroyed by gravity-affected blocks.

Steps to reproduce:

1. Place dirt/gravel/sand/cobble block near the base of the tree.
2. Place 2-3 more blocks on top of that one.
   Now you got floating tree! :D
   I think the best way to fix this is to make it that gravity-affected blocks don't fall in place of tree (I don't know how TFC checks blocks for that other than full/non-full blocks).

UPD: Now thinking of that, this is either DT or TFC bug, but I'll leave this issue open for now just in case.

Lag. Lots of it.

Related to #22. While generating chunks, the FPS is very bad whilst
around any areas with trees. BetterFps also does nothing to fix this.

Worldgen is much too crowded

TFC worldgen creates way too many trees if they're all as wide as normal DT.

"Vanilla" dynamic seeds?

Would it be possible to make it so that "vanilla" dynamic seeds can be placed on TFC dirt? (and the cactus on sand) as well as the outher addon's seeds? or is that something the "vanilla" dynamic tree's mod need to do?

.gitignore and gradle weirdness

Of course everyone hates gradle and the most important thing is that the setup works on the main dev's computer before anyone else's but i noticed a couple things that caused issues setting up the workspace:

• /gradle/ is gitignored presumably by accident, which is necessary to import the project and can't be generated on it's own
• the deps folder is designated one level up in the filetree (so in my idea projects folder rather than the project folder for DTTFC) which causes some weirdness, mainly that you can't runClient in dev (models will fail to load) and I also needed to put TFC in a /libs/ folder in the main dev environment in order to get it's classes to be recognized

[Bug] TFC Dynamic Trees aren't cut down properly

Using Dynamic Trees ver. 0.9.15 and DynamicTreesTFC ver. 0.9.14 (both the latest at time of writing), I've found that there's some very weird behavior when trying to cut down trees added by this patch, though not vanilla trees. Specifically, in creative, destroying a tree's trunk has no effect, and the removed block instantly reappears. In survival, the same thing happens, though the tree properly falls after a few seconds. Additionally, once the fallen tree disappears, there's a similar delay in the harvested wood & sticks appearing.

DT Ignores TFC Axe Damage Model

TFC calculates the amount of damage your axe takes depending on the size of the tree you chop down. IMO as it stands, without this feature axes beyond stone axe are somewhat pointless as a stone axe lasts quite a while.

Cascading worldgen lag

Modpack: Poetica - with some mod additions and all the mods updated (modlist: https://paste.ubuntu.com/p/fCSsBBkyfX/)

When exploring, there are constant lag spikes, and the log reads
[21:48:47] [Server thread/WARN]: DynamicTreesTFC loaded a new chunk [-62, 26] in dimension 0 (overworld) while populating chunk [-63, 26], causing cascading worldgen lag. [21:48:47] [Server thread/WARN]: Please report this to the mod's issue tracker. This log can be disabled in the Forge config.
etc. etc. etc.

vanilla dirt showing up on harvest and in strange placements

When a shovel is used to dig out the block under a DTTFC tree, the block dropped is vanilla dirt.

In the attached image, trees are placed into boulders on top of vanilla dirt mimic'ed blocks.

Pretty sure that's not supposed to happen. Maybe missing a soil type specification on the trees now?

Leaves don't fall out

Forge: 2855
TFC: 1.7.11.169
Dynamic Trees: 0.9.21
Dynamic Trees TFC: 0.9.16

When cutting down the foliage with scissors, nothing falls out

Project dead?

Seeds never plant?

I'm not really sure how it's supposed to work. I changed timeToLive to 200 and immediately noticed that the seeds never plant they just delete. Or is plantRate=0.125 too small and everything works how it's intended?

Branchblock models broken

Arborist Advancement

Currently, DTTFC makes TFC's Arborist advancement (obtain all 19 non-fruit saplings, in TerraFirmaCraft World) unobtainable, because TFC's original saplings are unobtainable with DTTFC's seeds having different item IDs. If practical, DTTFC should change the advancement (or recommend a datapack to downloaders) to require the new seeds, not the saplings which DTTFC removes.

vanilla dirt replaces all rooty blocks

translations for seeds are missing

Cannot chop down trees with GTCE axes.

This is because GTCE tools doesn't have tool classes, GTCE maintaner confirmed that this cannot be fixed on their side.
Tested with mod versions (all latest at the moment of writing this issue):
TFC: 1.7.9.167
DT: 0.9.21
DTTFC: 0.9.15
GTCE: 1.10.5.582
Other DT trees are fine, I guess this has to do with "No Tree Punching" 5ccc97d, I may suggest to have an option to check not only tool class but also tool oredict (craftingToolAxe)

Crash to Desktop and Corrupted Save

Was running at a higher tick speed to generate JoCodes (randomTickSpeed 100).

Crashed when I clicked a tree to cut it down in creative mode; the falling occurs normally, but when the tree hits the ground and stops, crash to desktop.

Got this crash report:

Description: Ticking entity

java.lang.IllegalStateException: ChunkData capability is missing.
at org.labellum.mc.dynamictreestfc.blocks.BlockRootyTFC.getDecayBlockState(BlockRootyTFC.java:28)
at com.ferreusveritas.dynamictrees.blocks.BlockRooty.updateTree(BlockRooty.java:182)
at com.ferreusveritas.dynamictrees.blocks.BlockRooty.func_180645_a(BlockRooty.java:148)
at com.ferreusveritas.dynamictrees.entities.EntityFallingTree.cleanupRootyDirt(EntityFallingTree.java:413)
at com.ferreusveritas.dynamictrees.entities.animation.AnimationHandlerFallover.shouldDie(AnimationHandlerFallover.java:244)
at com.ferreusveritas.dynamictrees.entities.EntityFallingTree.shouldDie(EntityFallingTree.java:353)
at com.ferreusveritas.dynamictrees.entities.EntityFallingTree.func_70030_z(EntityFallingTree.java:270)
at net.minecraft.entity.Entity.func_70071_h_(Entity.java:389)
at net.minecraft.world.World.func_72866_a(World.java:1993)
at net.minecraft.world.WorldServer.func_72866_a(WorldServer.java:832)
at net.minecraft.world.World.func_72870_g(World.java:1955)
at net.minecraft.world.World.func_72939_s(World.java:1759)
at net.minecraft.world.WorldServer.func_72939_s(WorldServer.java:613)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:767)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668)
at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:185)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526)
at java.lang.Thread.run(Thread.java:745)

Haven't been able to reopen the world save. I've now repro'd this one more time.

Strange arrangement of foliage or lack thereof

In the world, you can find 1-5 blocks of foliage that are not far from the main tree, but this foliage is not attached to the tree in any way. Also, some trees lack foliage until you cut it down.

One and the same tree, before and after cutting down.

Dirt still appearing

When you break a log other than the first one and it tries to regrow the soil turns into dirt (I made a small test with a control group of trees and the one that turned into dirt was the one where the soil said 0% life so I suspect soil that reaches 0% turns back into regular dirt)

Chopping down trees converts the block beneath to vanilla dirt instead of the tfc dirt as of DT-0.9.21 & DTtfc-0.9.15

When a dynamic tree gets big enough to convert it's block underneath to a rooty block and then gets chopped down, the block turns into vanilla dirt instead of the standard tfc version.

F.e: I chop down my hickory tree and the block that was underneath it isn't shale dirt, rather vanilla dirt.

Leaves prevent player passage

Leaves prevent players from passing through them (vanilla TFC TNG behavior). Not sure if this is an intended change or bug.

Mod Versions:
TFC 1.12-0.29.0.115
dynamictreestfc-0.9
DynamicTrees-1.12.2-0.9.7

Leaves don't have right colors

Can’t plant saplings from other addons in TFC soils

This issue was posted in the Extra Compat repository but I’m moving it here as I think it’s more appropriate.
DynamicTreesTeam/DynamicTrees-ExC#42

Comment from me:
Solution is easy, You can check how my The Aether addon registers Aether soil for every tree in registry that allows grass. The BoP addon also does this.

Op posted:
Other Dynamic Trees addons seem to work 💯 percent fine though.

[Bug] Dynamic TFC trees DO NOT generate in server side.

Forge version: 14.23.5.2855
Server: Forge
No other mods that affects World gen.

Only dynamic oak trees generate in world when using level-type=tfc_classic

[Suggestion] Rooty Soil doesn't convert to dirt.

Per Discord conversation I'm not a fan of the soil dirt system, that's not a fault of yours, it's just a personal preference.
Could a toggle to prevent rooty soil converting into dirt at all be implemented? This means once soil becomes rooty, it is from then onwards rooty soil. This means I could change how the block works in modpacks to instead drop roots and such, and allow reproducing dirts in other ways.
I'm cruel. This config would be amazing.

TLDR: doesRootySoilDirtify=false

Obey more DT config, make config option to override with TFC defaultish values

Since most players don't bother reading and expect out-of-the-box config to work, should add a config file/have a config option to alter DT defaults to match TFC as described on CF page/TFC #tng-addons channel.

Also I guess it should obey DT config file to disable treegen if players decide to stop using DTTFC in the middle of a game. Look into what that config option does besides disable treegen, sapling spawns?

Rooty soil should render as grass when grass is near it and not dirt?

This isn't appealing, it would make sense if it displayed as grass when connected to other grasses.

Log and Seed Drops are not balanced

Too few logs, too many seeds?

crash on start

crash on game start
https://gist.github.com/TheNimbleNinja/0a419f040fd5fd5186ccf3972e299ee8

logs don't drop

Breaking tree or branches crashes from not having a placed property ala blocklogtfc

I see two options to fix

1. make a new blocklogdttfc which doesn't have a differing hardness
2. get the placed property saved with the extended property, have to create new blockbranch

trees spawn on large boulders

Not sure why, but I still see the occassional tree on top of a raw stone block that is part of a large rock/boulder. The boulder gen code is executed first, so not sure how that happens.

BlockRootyTFC textures/model not working

TFC Dynamic Trees rooty soils don't convert back into TFC soils.

They convert into vanilla soils.

If it's a limitation of Dynamic Trees, and last I saw it was (from DT BOP), there are addons that fix it for themselves. Like Dynamic Trees Natura.

Tree saplings grow very fast

If i place nearby a lot of saplings they start growing very fast for some reason.

I use last version of addon.

Here is video with example - https://youtu.be/OWbBuOd0GZY

chop a tree bug (critical)

There is a bug - you can chop a tree with your hand and quickly enough. this breaks the mechanics of TFC.

dynamictreestfc-0.9.11

Drop issues

• Log Drops are empty
• Seed drops have no textures

unreleased code has NPE

I started to break the rootydirt block below a DTTFC tree, and got this crash/stacktrace. Ideas, @eerussianguy?

[14:44:42] [Client thread/FATAL] [net.minecraft.client.Minecraft]: Unreported exception thrown!
java.lang.NullPointerException: null
        at com.ferreusveritas.dynamictrees.models.bakedmodels.BakedModelBlockRooty.getParticleTexture(BakedModelBlockRooty.java:73) ~[BakedModelBlockRooty.class:?]
        at net.minecraft.client.renderer.block.model.SimpleBakedModel$Builder.<init>(SimpleBakedModel.java:92) ~[SimpleBakedModel$Builder.class:?]
        at net.minecraftforge.client.ForgeHooksClient.getDamageModel(ForgeHooksClient.java:835) ~[ForgeHooksClient.class:?]
        at net.minecraft.client.renderer.BlockRendererDispatcher.renderBlockDamage(BlockRendererDispatcher.java:46) ~[BlockRendererDispatcher.class:?]
        at net.minecraft.client.renderer.RenderGlobal.drawBlockDamageTexture(RenderGlobal.java:1938) ~[RenderGlobal.class:?]
        at net.minecraft.client.renderer.EntityRenderer.renderWorldPass(EntityRenderer.java:1375) ~[EntityRenderer.class:?]
        at net.minecraft.client.renderer.EntityRenderer.renderWorld(EntityRenderer.java:1259) ~[EntityRenderer.class:?]
        at net.minecraft.client.renderer.EntityRenderer.updateCameraAndRender(EntityRenderer.java:1062) ~[EntityRenderer.class:?]
        at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1119) ~[Minecraft.class:?]
        at net.minecraft.client.Minecraft.run(Minecraft.java:398) [Minecraft.class:?]
        at net.minecraft.client.main.Main.main(SourceFile:123) [Main.class:?]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_272]
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_272]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_272]
        at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_272]
        at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
        at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_272]
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_272]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_272]
        at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_272]
        at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
        at GradleStart.main(GradleStart.java:25) [start/:?]
[14:44:42] [Client thread/INFO] [STDOUT]: [net.minecraft.init.Bootstrap:printToSYSOUT:553]: ---- Minecraft Crash Report ----
// I let you down. Sorry :(

Future ideas

• Steal Fruit Tree models from DT Pam's

• Figure out how to build actual JoCode libraries from current parameters, like what ferreus did at https://github.com/ferreusveritas/DynamicTrees/wiki/JoCodes

• Fix RootyBlock textures to not just be andesite dirt

• Fix RootyBlock textures to show grass when grass is around

• See if more balance is needed in seed/log/stick drops