galex / name-that-color-intellij-plugin Goto Github PK

View Code? Open in Web Editor NEW

172.0 172.0 23.0 349 KB

This plugin lets you insert a name for a color you copy-paste or type in an android resource file.

Kotlin 100.00%

android-studio autocomplete colors demo intellij-plugin kotlin

name-that-color-intellij-plugin's Introduction

Hi there! 👋

🔭 I’m currently working on building an app for making pizzas!
🌱 I’m currently learning Jetpack Compose
💬 Ask me about Kotlin && Android in general :)
📫 How to reach me: Send me a tweet!

name-that-color-intellij-plugin's People

Contributors

Stargazers

Watchers

Forkers

suclike maoqis pentiumao pangbonn lucaseron sulemankhan447 androidlibrariesyoutube zwd-intellij timtsj theapache64 iamarjun ch8n orange-jun kasmadi17 iurkwan lzaytseva banhammerykt

name-that-color-intellij-plugin's Issues

Shortcut customisation

I can't find shortcut customisation feature. Is it there?

Add a quickfix

When a color is copied inside the document, provide a quickfix so the user does not need to move its carret till the text to apply the quickfix

Use name-that-color on existing color tags

Great plugin! I'd love to have the ability to change existing color names into their "real" color names instead of the ones we currently use. Would be awesome!

Android Studio freezes

After installing this plugin I noticed repeated freezes while typing code, waiting doesn't work.

After killing AS and reopening I also notice that the last few files edited were reverted, which adds to the severity of the problem.

Disabling the plugin made AS usable again.

Tried on AS 3.0.1 stable and 3.1 beta 4.

Android Studio 4+

Plugin Error: Plugin "Name That Color" is incompatible (target build range is 171 to 192.*).

The problem with ColorNameFinder's algorithm

I found one problem when I name the color of #444444.
"mine_shaft" was given by plugin, the same as the color of #222222, but they are a little bit different.
Then I input #444444 on the website name that color, but I got the name of "Tundora".

Steps to reproduce:

println(ColorNameFinder.findColor(HexColor("#444444")))

Actual result:

(#444444, Color(hexCode=323232, name=Mine Shaft, rgb=Rgb(r=50, g=50, b=50), hsl=Hsl(h=0, s=0, l=20)))

Expected result:

(#444444, Color(hexCode=4A4244, name=Tundora, rgb=Rgb(r=74, g=66, b=68), hsl=Hsl(h=345, s=6, l=27)))

I think the problem is at this line after I checked the source of ntc:

name-that-color-intellij-plugin/namethatcolor/src/main/kotlin/il/co/galex/namethatcolor/core/manager/ColorNameFinder.kt

Line 46 in 69d18a1

    
           val ndf2 = Math.pow((h - col.hsl.h).toDouble(), 2.0).toInt() + Math.pow((s - col.hsl.s).toDouble(), 2.0).toInt() + Math.pow((l - col.hsl.l).toDouble(), 2.0).toInt()

Let's look at the HSL value of three colors:

#4A4244  Rgb(r=74, g=66, b=68) Hsl(h=345, s=6, l=27)
#323232  Rgb(r=50, g=50, b=50) Hsl(h=0, s=0, l=20)
#444444  Rgb(r=68, g=68, b=68) Hsl(h=0, s=0, l=27)

Because H in HSL represents a degree, the delta value between #4A4244 and #444444 should be 15 but not 345. As a result, it makes #323232 be the closest color to #444444.

The fix should be something like this:

private fun deltaOfTwoDegree(l: Int, r: Int): Int {
    var delta = abs(l - r)
    if (delta >= 180) {
        delta = (360 - delta)
    }
    return delta
}

Hope it helps.

Misleading color names

After fix for #5 and adding Material Design colors, one name can mean different colors:

#FFEBEE gives red_50 as per Material Design palette
#80FF0000 gives red_50 as "red with 50% opacity"

Maybe it's better to use "red50" (no underscore) for Material Design colors, keep "red_50" for transparent colors.

Plugin version 1.2.0
Android Studio version 3.0.1

How can I use this plugin with latest Android studio?

Fix usage of "place" parameter in CompletionContributor.extend()

Find and fix use of "place" parameter in CompletionContributor.extend().
Especially the fact that what can be seen in the PsiViewer elements does not seem to be correct.

PsiWhiteSpace inside xmlText inside xmlTag with name resources
PsiWhiteSpace inside xmlText
PsiWhiteSpace

Same name for different shades of color.

I used #6002ee and #5300e8 these colors and choose name that material color and for the both colors it used deep_purple_a700 this name, also the name of theses color on material.io is purple 500 and purple 600.

Inject NameThatColor inside color context menu

Is this possible?

update README

Update the readme with two new gifs / images:

Copied color in the clipboard and typing CTRL+SPACE
Writing a color in the file and letting the quick fix show it can fix it (warning) and then typing ALT+ENTER

Show those for normal colors and for material colors.

Add support for Android Studio 3.5 / IntelliJ IDEA 2019.1

Android Studio 3.5 based on IntelliJ IDEA 2019.1 (191.6183.*) released at March 2019

The current version works only if I manually change restriction in META-INF/plugin.xml

Make plugin work with other Jetbrains IDEs (not just Android Studio)

I love http://chir.ag/projects/name-that-color and this plugin could be awesome... sadly I am not using Android Studio but PHPStorm, so I can't use it 😭

I have no idea how much work it will be, but would it be possible to create a version of this plugin that works with other IDEs, not just Android Studio?

Update to Android Studio 4.2

Android Studio 4.2 Canary 7
Build #AI-201.7846.76.42.6720134, built on July 30, 2020

Name that material color

As mentioned in this Reddit post, the same functionality would be useful for the Material Colors.

For this the project will become a library module which will build two plugins:

name that color (current one)
name that material color (new)

Plugin "Name That Color" is incompatible (supported only in IntelliJ IDEA).

I installed the plugin and after the restart, android studio get this error

plugin version

Android Studio version
4.1.3

Not compatible after update

this is version of android studio I use
Android Studio 4.1.2
Build #AI-201.8743.12.41.7042882, built on December 20, 2020
Runtime version: 1.8.0_242-release-1644-b01 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0
GC: ParNew, ConcurrentMarkSweep
Memory: 8158M
Cores: 4
Registry: ide.new.welcome.screen.force=true, external.system.auto.import.disabled=true, ide.balloon.shadow.size=0
Non-Bundled Plugins: PlantUML integration, com.intellij.apacheConfig, CheckStyle-IDEA, org.jetbrains.kotlin, com.codota.csp.intellij, com.potterhsu.jsonviewer, mobi.hsz.idea.gitignore, com.chrisrm.idea.MaterialThemeUI, izhangzhihao.rainbow.brackets, com.atlassian.bitbucket.references, wu.seal.tool.jsontokotlin

Plugin doesn't work in the Android Studio 3.2.1

The Plugin isn't working in the latest version of Android Studio (no context dialog is showed).

Android Studio 3.2.1
Build #AI-181.5540.7.32.5056338, built on October 9, 2018
JRE: 1.8.0_152-release-1136-b06 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.14

Plugin Version: v0.9.1 updated 03.02.18

Support for Jetpack Compose

Jetpack Compose will be stable on July this year. Will this plugin support Jetpack Compose soon?

It will be very useful to use this plugin on Compose.

Strings "add" word considered a color

Steps to reproduce:

Create a string resource with the name "add"
IntelliJ errors and wars this as a color

Actual result:
Warnings

Expected result:
No warnings

#fafafa gives no suggestions but #FAFAFA gives alabaster and grey_50
#2a000000 gives no suggestions but #2A000000 gives black_16