gams-dev/engine-ui

GAMS Engine UI

engine-ui's Issues

Namespace tab loses focus

This is not a bug, this is a feature request.
When I pick a namespace and patch a model, I go back to the namespaces page but my namespaces selection resets.
It would be nice to pass the name of the namespace I worked on while redirecting so I don't have to select a namespace again.

index.html is cached

Since index.html is cached, any changes we do is requiring clearing the cache before updating. We need to make sure that index.html is not cached.

Path parameters cannot contain / or \

While trying to upload a model if model name contains / or \, POST namespaces/{namespace}/{model} gives 404 as model contains /. Instead of trying to make this request, the UI should warn the user as model names cannot contain /.

• Creating a namespace POST namespaces/{namespace}
• Creating a model POST namespaces/{namespace}/{model}

Inviters can see 'Update Engine License' button

In the users tab, inviters can see 'Update Engine License' and 'Update GAMS License' buttons. They can't interact with them as they don't have enough permissions. We probably forgot to hide them.

UI use new endpoints to support text/stream entries located subdirectories

UI uses old endpoints to fetch stream and text entries and due to that the user cannot query text or stream entries when they are located in folders rather than the working directory.

Problem in usage interface

engine-ui/src/components/Usage.jsx

Lines 134 to 141 in 6bd5ded

	const isFinished = c.finished != null;
	let solveTime;
	if (isFinished && (c.times.length === 0 || c.times[c.times.length - 1].finish == null)) {
	solveTime = NaN;
	} else {
	solveTime = ((isFinished ? new Date(c.times[c.times.length - 1].finish) : new Date()) -
	new Date(c.times[c.times.length - 1].start)) / 1000;
	}

Usage interface gives an error message when isFinished is False and c.times is an empty array. This condition might happen to a race condition or when something went wrong. Maybe we can add another check to else and make sure the array is not empty before accessing it. Otherwise, it shows nothing.

I have also another issue with using NaN in the code. If I got it right, NaN + some number is NaN. So even if a single solve time is NaN, in the table we see that Solve time is NaN. Instead of that we can say 0, I guess?