ganz2016/simpleproxy

A simple SOCKS5 proxy server.

simpleproxy's Issues

Suggestion: shorten use lists

Instead of

use std::sync::mpsc;
use std::sync::mpsc::sync_channel;
use std::sync::mpsc::channel;
use std::sync::mpsc::SyncSender;
use std::sync::mpsc::Sender;
use std::sync::mpsc::Receiver;

(in client.rs) you can write:

use std::sync::mpsc::{self, sync_channel, channel, SyncSender, Sender, Receiver};

Ignoring Results is bad

This code, for example:

    pub fn write(&self, buf: Vec<u8>) {
        let _ = self.tx.send(Message::CSData(self.port_id,buf));
    }

It should probably return a Result rather than (), so that it can indicate failure.