gap-packages/fwtree

Computing trees related to some pro-p-groups of finite width

fwtree's Issues

Add CHANGES file

Tests fail with all packages loaded in GAP master

This test clones fwtree repository and tests it under GAP master. It runs out of memory if all packages are loaded.

Missing tests

Looking at gap-packages/gap-packages.github.io#9 still having fwtree, I am puzzled that a release published on March 8th does not have tst directory added in February in 6d3b12d#diff-9301c2a72c0f099d0313099f1cd54799. What happened?

Add standard tests

The package has no test files. It is recommended to have a TestFile component in PackageInfo.g to specify a short test (to run for no more than several minutes) which may be used to check that a package works as expected. For deposited packages, these tests are run regularly as a part of the standard GAP test suite. Please see ?TestPackage, ?Tests files for a GAP package and also ?TestDirectory for more information. You can find a sample setup in the example package at https://github.com/gap-packages/example.

These cam be added as a part of #1, or added separately, with subsequent rebase of #1.

Do not load XGAP via LoadPackage

fwtree/read.g

Line 11 in 899e884

XAV := LoadPackage("xgap");

This line causes a warning

#I  fwtree: Do not call `LoadPackage( "xgap", ... )' in the package file

while loading. Of course LoadPackage( "xgap", ... ) does not make sense at all, since it is started via a shell script. The point is only to test whether it is loaded or not.