Giter Site home page Giter Site logo

Comments (6)

rfranzke avatar rfranzke commented on July 16, 2024 2

I agree with the image vector argument: This should be enough to overcome the challenges you described. We don't run infrastructure to mirror each and every image that is somewhere referenced in our open-source repositories.

The other extensions already default to gcr for their images, hence I created this issue.

The reason is that we build the CCMs for AWS, Azure, etc. ourselves with https://github.com/gardener/cloud-provider-azure, so we also push the image to our registry. With OpenStack it's different because we don't have to build it and can just consume the communities image.

I suggest closing the issue.

from gardener-extension-provider-openstack.

vpnachev avatar vpnachev commented on July 16, 2024

There is https://github.com/gardener/gardener-extension-provider-openstack/blob/master/pkg/imagevector/imagevector.go.
It can be controlled via

# images:
# - name: pause-container
# sourceRepository: github.com/kubernetes/kubernetes/blob/master/build/pause/Dockerfile
# repository: gcr.io/google_containers/pause-amd64
# tag: "3.0"
# version: 1.11.x
# - name: pause-container
# sourceRepository: github.com/kubernetes/kubernetes/blob/master/build/pause/Dockerfile
# repository: gcr.io/google_containers/pause-amd64
# tag: "3.1"
# version: ">= 1.12"
.

So whoever wants to avoid the docker limits can overwrite the default images from https://github.com/gardener/gardener-extension-provider-openstack/blob/master/charts/images.yaml.

Is there anything else that you want to add?

from gardener-extension-provider-openstack.

ialidzhikov avatar ialidzhikov commented on July 16, 2024

+1, I don't see why we have to maintain the images also in GCR. There is imagevector overwrite and locally (or wherever) you can set it to whatever.

from gardener-extension-provider-openstack.

vlerenc avatar vlerenc commented on July 16, 2024

At runtime/in production the image vector should always/only pull images from our GCR.

That's to keep the failure domain small and because we are very satisfied with GCR performance and availability (other than Quay/Docker Hub that had downtimes in the past that impacted Gardener before we started mirroring images to our GCR).

from gardener-extension-provider-openstack.

ialidzhikov avatar ialidzhikov commented on July 16, 2024

At runtime/in production the image vector should always/only pull images from our GCR.

That's to keep the failure domain small and because we are very satisfied with GCR performance and availability (other than Quay/Docker Hub that had downtimes in the past that impacted Gardener before we started mirroring images to our GCR).

Sure, I agree. But we should not maintain each and every image to GCR just because the imagevector logic can be broken. We had an issue in the imagevector logic and we will fix it. It is just too much effort to double maintain all of similar images and I don't like the idea at all as I shared in similar discussions in the past.

from gardener-extension-provider-openstack.

kon-angelo avatar kon-angelo commented on July 16, 2024

There were a couple of CCloud cases in the recent days, where they hit the dockerhub limit when deploying shoots. It's also a situation that can plague CCloud more than other providers.

Maybe it's not an issue directly of this repo and can be moved to an issue of the landscape, but the problem remains and the images need a more reliable source than DockerHub. The other extensions already default to gcr for their images, hence I created this issue.

from gardener-extension-provider-openstack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.