garetht/amanar

Tool to refresh database app credentials from HashiCorp's Vault

amanar's Issues

Allow for additional Vault auth mechanisms.

We're using Vault, but not with the github auth plugin. This issue is to float the idea of enabling/allowing for additional types of authentication w/ Vault.

The list supported by HashiCorp directly are here: https://www.vaultproject.io/docs/auth

In our specific case we are using:

https://github.com/jetstack/vault-plugin-auth-google

To auth via GSuite. We're prototyping options on a fork and would like to confirm that PR's are welcome to enable something like this.

Please advise and thanks!

amanar is missing a license file

I'm finding amanar quite useful, and would like to contribute.

Could you please add an open source license? I want to ensure that when contributing I'm doing things correctly.

From: https://help.github.com/articles/licensing-a-repository/#choosing-the-right-license

You're under no obligation to choose a license. However, without a license, the default copyright laws apply, meaning that you retain all rights to your source code and no one may reproduce, distribute, or create derivative works from your work. If you're creating an open source project, we strongly encourage you to include an open source license. The Open Source Guide provides additional guidance on choosing the correct license for your project.

Note: If you publish your source code in a public repository on GitHub, according to the Terms of Service, other GitHub users have the right to view and fork your repository within the GitHub site. If you have already created a public repository and no longer want users to have access to it, you can make your repository private. When you convert a public repository to a private repository, existing forks or local copies created by other users will still exist. For more information, see "Making a public repository private."

We are currently working in a fork, but have as a specific goal to contribute back to this project.

Thanks!

Potential import collision: import path should be "mvdan.cc/sh", not "github.com/mvdan/sh"

Background

I find that mvdan.cc/sh and github.com/mvdan/sh coexist in this repo：
https://github.com/garetht/amanar/blob/master/go.mod （Line 14 & 25）

github.com/mvdan/sh v2.6.4+incompatible
mvdan.cc/sh v2.6.4+incompatible // indirect

That’s because the mvdan/sh has already renamed it’s import path from "github.com/mvdan/sh" to "mvdan.cc/sh". When you used the old path "github.com/mvdan/sh" to import mvdan/sh, go will reintroduces mvdan/sh through the import statements "import mvdan.cc/sh/…" in the go source file of mvdan/sh.

https://github.com/mvdan/sh/blob/v2.6.4/expand/braces.go#L6

package expand
import "mvdan.cc/sh/syntax"

The "mvdan.cc/sh" and "github.com/mvdan/sh" are the same repos. This will work in isolation, bring about potential risks and problems.

Solution

Follow the requirements of mvdan/sh doc:

package syntax
> import "mvdan.cc/sh/syntax"

Package syntax implements parsing and formatting of shell programs. It supports POSIX Shell, Bash, and mksh.
…

Replace all the old import paths, change "github.com/mvdan/sh" to "mvdan.cc/sh ".
Where did you import it: https://github.com/garetht/amanar/search?q=github.com%2Fmvdan%2Fsh&unscoped_q=github.com%2Fmvdan%2Fsh