garysharp/dnsserverapi

Generic DNS Server querying and management

dnsserverapi's Issues

NS Record is deleted when trying to update it.

Hi Gary,

I think I found a bug in your code, but can you please check.. The steps I make to reproduce it is:

1. create a new zone
2. then update the SOA record with the information I need.
3. then update the NS record that is automatically created by the MS DNS server.

When I update the NS record and it invokes the var wmiResult = instance.InvokeMethod("Modify", wmiParams, null); the record is deleted on the server. It updates the SOA record fine.

The function is this one:

        public static void ModifyRecordInternal(this WindowsDnsZone zone, DnsRecord record)
        {
            if (zone == null)
                throw new ArgumentNullException(nameof(zone));
            if (record == null)
                throw new ArgumentNullException(nameof(record));

            var state = zone.GetRecordStateInternal(record);

            if (state == null)
                throw new ArgumentException("Record must be created by the provider");

            using (var instance = zone.server.WmiGetInstance(state.WmiPath))
            {
                using (var wmiParams = instance.GetMethodParameters("Modify"))
                {
                    wmiParams["TTL"] = (uint)record.TimeToLive.TotalSeconds;

                    // populate record-specific parameters
                    PopulateRecordParameters(zone, record, wmiParams);

                    var wmiResult = instance.InvokeMethod("Modify", wmiParams, null);
                    var wmiPath = (string)wmiResult["RR"];
                    var newState = new WindowsDnsRecordState(wmiPath);

                    zone.SetRecordStateInternal(record, newState);
                }
            }
        }

on a side note, should your code automatically update the NS record (if needed) when the SOA record is updated or what is your take on that?

Let me know if you want TCPdumps of the actual traffic.

Esben