gass/libads

Implementation of BECKHOFF's ADS protocol.

libads's Issues

AdsRouter needs to be implemented

A notification and connection management, similar to the oficial AdsRouter should be implemented

Provide working examples

The examples must be simplified and all must be usable with the current library.

Crash in AdsGetLocalAddress

Crash in AdsGetLocalAddress() when accessing the 'sa_family'. I have several network adapter and I'm using xubuntu 12.04.

examples don't work

Some examples are outdated or can't compile.

They are not compiled when the full suite is.

Debug function issues

• in a function void analyze(uc * p1). The evaluation
  ((p->amsHeader.stateFlags && 1) == 0)
  is true in wrong cases. A value 0x01 is a request flag in a stateFlags field, thus there should be a bitwise AND (&) instead of boolean one;
• same function - debugging of a read command:
  _ADSDump("Data: ", (uc *) p1 + 44, rr->length); - the shift should be by 46 not 44 bytes (the best thing is to use sizeof() of structures like ADSreadRequest and headers (it seems to me so);
• ADSaddDeviceNotificationRequest structure - comment seems to be wrong. It states for maxDelay and cycleTime members: "unit is 100ns". This is ok according to the ADS-DLL api, however when one fills raw bytes (as is in case of the structure), it's expressed in 1ms.

Provide a debian package

A debian package should be provided for easy instalation and test.

Library expects ads packets to be maximum 1 ethernet frame

The library expects a packet to never exceed one ethernet frame. This is not a limitation in ADS it self.

All packets are read to this variable:
dc->msgIn

Which is a stack variable of 1524 bytes.
This variable should instead be dynamically allocated heap according to the length specified in the ads read/write command.