gatheringhallstudios/mhworlddata

Generate a SQLite file from MHW data

Jekyll website repository for gatheringhallstudios.com

mhworlddata's Issues

Complete location_items.csv using smaller official guide data

The current version of location_items.csv is from Kiranico, which I believe used the (smaller) official guide. However, they didn't list the node type and node drop table (common/rare aka shiny). If anyone has that guide and is willing to add the information here, I'd certainly love the help.

The idea would be to add a node_type and node_rarity column. node_type would be ore, bones, redore, etc. node_rarity would be common or shiny.

Also, apparently some maps have "merged areas" for the spawning of certain nodes. If that's true, updating the specific entries to refer to the merged sum would be helpful. I hear this happens in Elder's Recess 5 and 6, so an area 5 or 6 would be the area of that node.

Can't get script to build DB

I finally got Python 3.6 with SQL Alchemy 1.2.5 on my computer and when I try to build I get this error:

Traceback (most recent call last):
File "/Users/HumanShetty/Downloads/MHWorldData-master/build.py", line 144, in
build_armor(session)
File "/Users/HumanShetty/Downloads/MHWorldData-master/build.py", line 128, in build_armor
raise Exception(f"ERROR: Item {item} in Armor {armor_name_en} does not exist")
Exception: ERROR: Item Earth crystal in Armor High Metal Mail does not exist

Do you have any idea whats going on?

Armor bonus skills

Hello!

I don't see the armor bonus skills currently in the database, like 2 pieces of rathalos set given rathalos mastery (i.e. Elementa Crit) is this information somewhere? Are there any plans for it to be added?

Thank you!

Maintenance Jewel is not included

There isn't Maintenance Jewel in the list of decorations.

English: Maintenance Jewel 1
Japanese: 整備珠【１】
Chinese: 整備珠【１】
Korean: 정비주 【1】

Incorrect shrieking legiana data: shock/pitfall traps should be TRUE

https://github.com/gatheringhallstudios/MHWorldData/blob/master/source_data/monsters/monster_base.csv#L67

The shrieking legiana can be caught by shock/pitfall traps I believe, and the source data in the repository says it can't.

Missing fire and ice alt forms alatreon

Once .db is generated, Alatreon loses the ice and fire form, only dragon active.
i'm missing something?

python merge.py binary update issue

(MHWorldData-UozLJLHE) F:\MHWorldData>python merge.py binary update
Binary armor data loaded
Existing Data loaded. Using existing armorset data to drive new armor data.
Writing list of armorset names (in order) to artifacts
Updating set data, keyed by the existing names in armorset_base.csv
Armorset entries updated
Updating armor
Armor files updated

Item files updated
Existing Data loaded. Using to update weapon info
Loaded initial weapon binary data data
Loaded great-sword weapon tree binary data
Loaded long-sword weapon tree binary data
Loaded sword-and-shield weapon tree binary data
Loaded dual-blades weapon tree binary data
Loaded hammer weapon tree binary data
Loaded hunting-horn weapon tree binary data
Loaded lance weapon tree binary data
Loaded gunlance weapon tree binary data
Loaded switch-axe weapon tree binary data
Loaded charge-blade weapon tree binary data
Loaded insect-glaive weapon tree binary data
Loaded light-bowgun weapon tree binary data
Loaded heavy-bowgun weapon tree binary data
Loaded bow weapon tree binary data
Skipping Twin Nails element data
Skipping Fire and Ice element data
Could not find binary entry for Taroth Daggers "Fire"
Weapon files updated

Item files updated

I see that "Could not find binary entry for Taroth Daggers "Fire", is it normal?

Add Kulve Taroth's weapons

Hey!

Add Kulve Taroth's weapons, that will be pretty useful :)

Here are two links for the weapons:
Taroth Weapons
Taroth Weapons 2

Both of the above links are community driven, there are no official source of this data to my knowledge, I could be wrong and that would be very good but unfortunately I think thats the best we have.

I'm farming kulve and using the first spreadsheet as a reference for things I'm looking after, and so far the data seems pretty accurate, I have around 30 ~ 50 weapons, and checked a good amount of them, they are present in the spreadsheet and with correct data.

Since the list is a spreadsheet it can be easily programmatic converted to the format you use.

Thanks for your awesome work so far :)

Holy Sabers (id: 291 in weapons table) have wrong rarity

Hi there!
First of all I wanted to thank you for the awesome work you've done extrapolating all the data and formatting it nicely in a database.
I've noticed that the Holy Sabers (as mentioned in the subject) have a wrong rarity (252, instead of 7). The csv file you've used seems to be fine, so I don't know where the issue could be.

How to update the data in source_data/armors/armorset_*.csv?

How to update the data in source_data/armors/armorset_*.csv?
I run the code in merge.py and wrote some my own codes to do more process, but then I find the data of armorset was not updated like other files. How can I update them ?

Test Webhook

Test issue to test a webhook

[Question]: Iceborne Support?

Hello,

Just wanted to open up the discussion for Iceborne support in this project? Is the plan to wait until the PC release of MHW IB?

Build Error: expected an indented block

In the most recent change of the mhdata/build/sql.py at line 655, an if statement was added without the correct indentation, stopping the build.

The error log:
$ pipenv run python build.py
Traceback (most recent call last):
File "build.py", line 4, in
from mhdata import build
File "C:\Users\Jacob\Documents\GitHub\MHWorldData\mhdata\build_init_.py", line 8, in
from .sql import build_sql_database
File "C:\Users\Jacob\Documents\GitHub\MHWorldData\mhdata\build\sql.py", line 656
weapon.skills.append(db.WeaponSkill(
^
IndentationError: expected an indented block

Solution:
I fixed it on my end by correcting the indentation.

Do you have any guidelines for proposing changes?

I'd also be happy to contribute more to the project as a whole. :)

Decide the data that goes into the base or extended maps

Currently, most data exists in the data maps. However, I'm thinking of moving most of them to the base map, and leave "extra" data (like crafting data, sharpness, etc) to data maps. Some more thinking needs to be done on what data will be moved to the base map.

My current thoughts are rarity, monster size, weapon type, and weapon attack. I have no idea what I should move regarding armor information.

15,000

Foreign Keys -- are they working?

I thought that foreign keys, when referencing composite primary keys, need to also reference the full composite (can't be partial)?

For example any foreign keys that reference location_text need to have (id, lang_id) as the foreign key.

On my phone, so typing from memory, but will be able to provide a code example when I get back on my PC if this doesn't make sense.

Reproduction would be to run a PRAGMA foreign_key_check; on the database

I'm unfamiliar with sqlite but the error about an foreign key constraint violation popped up when I was migrating the db to a postgresql server

Sharpness data

Hello guys.

I think I can help about sharpness data, I already wrote a tool in C# that extracts sharpness data from http://mhwg.org and it's very accurate. Actually I double checked all the data with the game, there were a few mistakes that I reported to this site, and they fixed it pretty quickly.

The tool is there is you want to have a look at the source code.
https://github.com/TanukiSharp/MHWSharpnessExtractor

If you want to me to modify it to generate output data in a different way, please let me know.
There is a lot of work done to output data for https://github.com/LartTyler/MHWDB-API but I can adjust / change for your convenience.

Let me know.