Comments (11)
Hey man, good catch.
Should be sorted by this PR #68
I'm hoping to get a release out in the next hour or so to fix the issue.
from pubg-dotnet.
Sweet! Thanks!!
from pubg-dotnet.
#72 going through CI now, should release automatically after it's merged
from pubg-dotnet.
I'll create a PR to the Pubg API docs too since they don't actually have those game modes listed
from pubg-dotnet.
Forgot to merge before I left for the gym, my bad!
Release build has started now: https://ci.appveyor.com/project/GavinPower747/pubg-dotnet/build/1.7.0.137
After that's finished nuget will take a few minutes to verify and it'll be live
from pubg-dotnet.
Looking much better!! Thanks!
from pubg-dotnet.
I see a few more Game modes that are not defined. Below are the GameModes and an example MatchID.
Not sure how many more of these modes there will be and if there is a better way to handle these since it seems they are creating new modes on a regular basis...
Message "Error converting value "acpfpp" to type 'Pubg.Net.PubgGameMode'. Path 'data.attributes.gameMode'." string
matchID "b7d42d9d-6d40-4022-b834-ca9e8dcf6072" string
Message "Error converting value "flarefpp" to type 'Pubg.Net.PubgGameMode'. Path 'data.attributes.gameMode'." string
matchID "c4d6766b-9f44-4bdc-8836-a37c734fb7e6" string
Message "Error converting value "flaregunfpp" to type 'Pubg.Net.PubgGameMode'. Path 'data.attributes.gameMode'." string
matchID "cde6bd4c-9835-4efb-aa7d-d9ee11c0e8fd" string
Message "Error converting value "pgifpp" to type 'Pubg.Net.PubgGameMode'. Path 'data.attributes.gameMode'." string
matchID "6e4d51b7-543d-49d8-8940-b9dacf25aff2" string
from pubg-dotnet.
Hey man sorry, I've been out of the country for the past while. They seem to be throwing everything and anything into there with absolutely no warning, I may have to just make that field a string.
from pubg-dotnet.
No worries! Yeah it does seem like that. Hard to keep constants when they throw whatever/whenever without a notice. Hopefully the trips were good!
from pubg-dotnet.
Apologies for the delay but the first version with the string has been launched
https://www.nuget.org/packages/Pubg-DotNet/1.8.0
from pubg-dotnet.
Sorry for the delay, but it all looks good now!
from pubg-dotnet.
Related Issues (20)
- Why are matchids empty?
- Missing Krakin Map Name
- Updating JsonApiSerializer from 1.3.1 to 1.74 HOT 1
- Add more maintainers
- Update to be in line with API 1.2.0 HOT 1
- Add is custom match flag HOT 1
- PUBG new Map HOT 3
- GetPubgMatchesRequest is missing HOT 7
- Create more documentation HOT 3
- Create Tournament Service HOT 1
- Changing PubgGameMode to String HOT 1
- Relationship Id's are lost on multiple deserializations HOT 1
- Message "Unable to find specified resource" string HOT 3
- Service Methods Split into PC and Xbox for 2.0.0 and Potential Delays HOT 3
- Json Exception HOT 2
- Always NullReferenceException HOT 4
- New map 'DihorOtok_Main' HOT 3
- DBNO information
- PubgGameMode enum is out of date HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pubg-dotnet.