Warning suppression macros conflict with those provided by ign-cmake

[gazebosim]

Warning suppression macros conflict with those provided by ign-cmake

[chapulina]

Perhaps we need to wrap all our #define statements in #ifndef?

+1

[azeey]

I was wondering why the warning didn't show up on Linux. It turns out the warning is emitted if the definitions are different. On Linux they are the same, but on windows, ign-cmake has

#define DETAIL_IGN_UTILS_WARN_IGNORE__NON_VIRTUAL_DESTRUCTOR \
  DETAIL_IGN_UTILS_BEGIN_WARNING_SUPPRESSION(4265) \
  DETAIL_IGN_UTILS_BEGIN_WARNING_SUPPRESSION(5205)

while ign-utils has

#define DETAIL_IGN_UTILS_WARN_IGNORE__NON_VIRTUAL_DESTRUCTOR \
  DETAIL_IGN_UTILS_BEGIN_WARNING_SUPPRESSION(4265)

I can add the #ifndef, but I'm not sure how we deal with different versions of the macro in two places going forward. It seems like it would lead to confusion. Changing the macro names might be better.

[chapulina]

while ign-utils has

In this case, I think 5205 could be added to ign-utils's macros.

Changing the macro names might be better.

+1

[chapulina]

Addressed in #10

[scpeters]

In this case, I think 5205 could be added to ign-utils's macros.

I think it would make sense to do this as well

[scpeters]

In this case, I think 5205 could be added to ign-utils's macros.

I think it would make sense to do this as well

#11