gdcolon/vvvvvv-pygame

A recreation of VVVVVV, made from scratch in Pygame!

vvvvvv-pygame's Issues

Batch file error

(removed)

[FEATURE] Provide compiled executable for easier access - compilation snippet included

Hi, I think providing an executable will be nice for people who just want to run and play.
I have provided executable arguments to bundle the game with pyinstaller below.
This code will bundle the game without confirmation, as a windowed application, and sets the name to VVVVVV and adds other files required to make the game work. For MacOS, change the icon to a .icns and for Linux to a .png
If you would like me to provide the compiled files for a windows machine, please reply here and I'll send a PR.

in order to run the following code, please install pyinstaller pip install pyinstaller
The following code assumes you have vvvvvv installed to C:\vvvvvv. You may change the directory at any time.
The icon must be converted to a .ico or .icns for operating systems besides Windows or MacOS.

pyinstaller --noconfirm --onedir --windowed --icon "C:/vvvvvv/icon.ico" --name "VVVVVV" --add-data "C:/vvvvvv/assets;assets/" --add-data "C:/vvvvvv/laboratory;laboratory/" --add-data "C:/vvvvvv/spacestation;spacestation/" --add-data "C:/vvvvvv/warpzone;warpzone/" --add-data "C:/vvvvvv/levels.vvvvvv;." --add-data "C:/vvvvvv/palette.py;." --add-data "C:/vvvvvvr/records.vvvvvv;." --add-data "C:/vvvvvv/Sprites.txt;." --add-data "C:/vvvvvv/spritesheet.py;."  "C:/vvvvvv/vvvvvv.py"

vvvvvv.bat

change py3 to python as its most used/common.

Some tips for improving a good code

Hello,
(sorry for my english, I'm french)
I'm in front of this GitHub page following your video on Youtube. Indeed, after being impressed by the quality of the game, I wanted to take a look at your code.
So I open this issue for the purpose of advising you. Indeed, I could not help but notice some simple detail to improve which can just greatly improve the quality of your code (being already very good).
The first remark I could make to you is that a 1,200 line file is just not possible ^^. Besides being complicated to navigate, it's anything but practical. My advice will be to at least separate the classes into separate files.

Also, another small detail (in itself, it works perfectly with, but it is not recommended) the use of global is anything but advisable. (more informations here)
I know sometimes, it's hard to remove them, but a code whitout global is a better code ^^.
I hope my advice will be useful in your future as a developer, and I wish you good luck on your future projects!
(don't mind my GitHub's project, I don't have a lot of public repo, I prefer keep them private)

Spacestation.ogg file missing.

The .\assets\music\spacestation.ogg file is missing from the directory.