gemini-testing/gemini-core

[DEPRECATED] Utility which contains common modules for gemini and hermione.

gemini-core's Issues

`2.6.2` does not contain `lib/coverage/coverage-level`

After yesterdays package update to 2.6.2, I get when running gemini:

Error: Cannot find module './lib/coverage/coverage-level'
    at Function.Module._resolveFilename (module.js:555:15)
    at Function.Module._load (module.js:482:25)
    at Module.require (module.js:604:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/nix/store/szgph11cai3sf5w52b3hv3hkc2kqfsjl-mhc-node-modules/node_modules/gemini-core/index.js:20:24)
    at Module._compile (module.js:660:30)
    at Object.Module._extensions..js (module.js:671:10)
    at Module.load (module.js:573:32)
    at tryModuleLoad (module.js:513:12)
    at Function.Module._load (module.js:505:3)
    at Module.require (module.js:604:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/nix/store/szgph11cai3sf5w52b3hv3hkc2kqfsjl-mhc-node-modules/node_modules/gemini/lib/passthrough-emitter.js:4:20)
    at Module._compile (module.js:660:30)
    at Object.Module._extensions..js (module.js:671:10)
    at Module.load (module.js:573:32)

Looking into my node_modules folder this file does indeed not exist. It is also not included when downloading the tgz directly from npm. Can you publish a new version that includes the file?

Update micromatch at least to v3

npm audit reports a vulnerability in braces second-level dependency:

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low           │ Regular Expression Denial of Service                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ braces                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=2.3.1                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ hermione                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ hermione > gemini-core > micromatch > braces                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://www.npmjs.com/advisories/786                         │
└───────────────┴──────────────────────────────────────────────────────────────┘

micromatch@3 depends on braces@2 which has the fix

Add TypeScript support

To support TypeScript we only need to add .ts to https://github.com/gemini-testing/gemini-core/blob/master/lib/sets-builder/index.js#L11

We could also look at refactoring to get the formats from the gemini config sets.

We could raise an initial PR with the trivial fix, and then look into whether the more robust solution is feasible.

We're also happy to add the types to DefinitelyTyped and to publish a gemini-typescript plugin.

Sets-builder should exit with error if path/grep do not contain at least a single file

There is suggestion to change this function https://github.com/gemini-testing/gemini-core/blob/master/lib/sets-builder/index.js#L77 to fix this issue gemini-testing/testplane#536

New patch version

Can you please release a new patch version with the package.json fix? Thanks