gemini-testing/glob-extra

glob-extra's Issues

.sock file is directory

node v12.16.1
https://github.com/gemini-testing/glob-extra/blob/master/lib/utils.js#L12
(await isFile('some-sock.sock')) === false

Incorrect expandPaths behavior in 4.0.1

OS: Windows 10.

4.0.0:

node
> const globExtra = require('../lib/index');
> globExtra.expandPaths(['C:\\some_file.txt']).then(a => console.log(a));
[ 'C:/some_file.txt' ]

4.0.1:

node
> const globExtra = require('../lib/index');
> globExtra.expandPaths(['C:\\some_file.txt']).then(a => console.log(a));
[]

This makes Gemini and Hermione unusable.

Throw error or warning if path do not match any file.

Problem:

If we pass array with one or more invalid path they just just skipped. It may be an issue because after calling require('glob-extra').expandPaths we don't know how many paths are not valid or is there any?

Example:

const paths = getArrayFromUserInput(); // ['./right/path/but/with/typoo/5.js', './path/that/do/not/exist/1.js', './path/to/two/or/three/files/*'];
const resolved = require('glob-extra').expandPaths()paths;
functionThatUserExpectsWorkOnFiveLinksButWorksOnFour(paths);

Solution:

Make new option options.errorOnNoMatch that will throw error it any of array's path do not match file.

// glob-extra/lib/index.js:11
const getFilesByMask = (pattern, options) => {
  const files = fg.sync(pattern, options);
  if (options.errorOnNoMatch && files.length == 0) {
    throw new Error('Could not match any files with given patten: ' + pattern);
  }
  return Promise.resolve(files);
};