Giter Site home page Giter Site logo

gentics / gentics-ui-image-editor Goto Github PK

View Code? Open in Web Editor NEW
16.0 16.0 4.0 13.24 MB

An Angular module for cropping, resizing and setting the focal point of images.

Home Page: http://gentics.github.io/gentics-ui-image-editor

License: Apache License 2.0

JavaScript 16.61% HTML 13.27% TypeScript 61.07% CSS 9.05%

gentics-ui-image-editor's People

Contributors

michaelbromley avatar netwarex avatar tommazzo89 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

gentics-ui-image-editor's Issues

Misplaced crosshair when opening in modal

Hi, this is a really easy to use component, thanks for this. Although, I have some issues.

As mentioned in #1, it would be a good idea to able to set initial values. For now I did it via the modal interface, directly setting the focalPointX and focalPointY, and it works well.

Sadly, sometimes the crosshair is misplaced from the initial set focal point values. eg.: I edit an image, set the coordinates, save it, close the modal. Then I reopen it, it provides the last time saved coordinates, it show up as it should, then after the third or fourth time I reopen the modal this way the crosshair is moved by some pixels left. And after the next reopens it is kept here.

There are some images, where it is not happens. Also when the crosshair misplaced and I click on edit focal point, the editor crosshair is placed on the right place. I think the issue is with the animation of the modal or the size of the image.

Do you have any idea, why does it happens?

Thanks in advance!

Suggestions

Hi - As already stated before, thanks for this very awesome implementation!

I have a few suggestions / proposals:

  1. Rename the (transformation) output to (transformationChange) and add an input transformation - there is currently no way to supply already existing scaling/cropping/focalpoint information to the editor.
    @Input() transformation & @Output() transformationChange would allow consumers to use double-binding.

  2. Disable text selection for the interactive elements (e.g. mode buttons, "aspect ration" text)
    When a user switches between modes and has the mouse down for a tad too long, the text below the buttons gets selected

  3. When in mode X, switch back to the overview when canX changes to false

  4. Exact scaling via text input
    e.g. width shows "1,921px", but as <input value=1,921><span>px</span>
    User could update the value to an exact value (1920px)

  5. Use default (non-interactive) cursor for mode button when in a mode
    e.g. after clicking on "scale", the button on the left side still shows the hand cursor, but can not be interacted with it

I'd be happy to hear your opinion/input.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.