geoffleyland/rima

Rima is a tool for formulating mathematical models

rima's Issues

Memory Leak/Corruption?

Hi Geoff,
I got your repository and integrated it into luajit and I must tell you this is a wonderful work.
Doing some tests I found something that is related to a possible memory leak/issue that broke my luajit integrated stuff.
This actually happened only using ipopt and the core dump happened when the GC entered into action.
I think I have fixed it but I don't want to mess your stuff in Github :)
So I'm simply telling you what I did in the file rima_ipopt_core.cpp:

1. commented out the destructor ~rima_ipopt_problem (lines 45 and 137-140)
2. changed the function rima_delete like this:

static int rima_delete(lua_State L)
{
rima_ipopt_problem *model = (rima_ipopt_problem)luaL_checkudata(L, 1, metatable_name);
model->ReleaseRef((Ipopt::Referencer*)L);
//model->~rima_ipopt_problem();
luaL_unref(L, LUA_REGISTRYINDEX, model->model_index_);
return 0;
}

basically putting the unref directly in the delete and not using the cached L_ state.
In this way this is not crashing and is not leaking.
Hope this helps and thanks for the work you shared.

Mauro
;)

lp_solve bug with add_constraintex

As noticed by Kevin:

I also noticed an lp_solve bug. When using add_constraintex, you should initially have 0 rows, because the add functions create a new row. Hence you are ending up with double the number of rows. This is easily fixed by doing make_lp(0, cols); resize_lp(rows, cols); as resize_lp doesn't add the rows, just allocates the memory.